fix sed handling in macOS #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcnaveen
changed the title
|
Okay! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
This PR does two different things.
write_secretsfunction outside ofgenerate_secretsto avoid nested functions.Desc
sed behaves differently on GNU and macOS.
The —i '' syntax correctly tells macOS's sed not to create a backup, which is the required form. The script also uses | as a delimiter for the sed substitution, which can sometimes make the script more readable and avoid conflicts with / characters in paths or values.
Test
Tested on macos sequoia 15.0.1 (24A348) & Linux Ubuntu 6.8.0-45-generic (Ubuntu 22.04)
Resolves #6