notify large json (#182, #186) #206
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #186 and #182 by improving file size handling and error notifications.
Changes
File size handling
maxSize: 1024 * 1024 * 5
)onDropRejected
with clear error messagesError handling
User experience
Technical details
Client-side (
DragAndDropForm.tsx
)Server-side (
createFromFile.ts
)JSON validation (
jsonDoc.server.ts
)Issues resolved
Issue #186: "Notify if file is too big"
Issue #182: "Local JSON Hero failing on 25K line file"
Testing
Screenshots
Before
After
Breaking changes
None.
Checklist
Related issues
Additional notes
This improves the experience for large JSON files while maintaining performance and reliability. Users get clear, actionable feedback when encountering file size or JSON parsing issues.