Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add job management API endpoints #406

Closed
wants to merge 5 commits into from
Closed

feat: Add job management API endpoints #406

wants to merge 5 commits into from

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Aug 26, 2023

This PR adds job management API endpoints exposed via a new class named TriggerManagementAPI

image

/claim #388

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2023

⚠️ No Changeset found

Latest commit: b1973a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam
Copy link
Member

ericallam commented Aug 28, 2023

Thanks for this @neo773! Our front-end guru who will be picking this front-end design up is away for the week on holiday so it might be awhile before we can get this one in to main.

@neo773
Copy link
Contributor Author

neo773 commented Sep 4, 2023

@ericallam Any updates?

@ericallam
Copy link
Member

Sorry this has been in a holding pattern, our designer @samejr is hopefully going to get to this next week 👍

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the API endpoints should be at this path: /manage/api/v1/.

It's a separate API from the main one.

@samejr
Copy link
Member

samejr commented Sep 15, 2023

@neo773 working on the UI now...

@samejr
Copy link
Member

samejr commented Sep 19, 2023

/tip $200

@algora-pbc
Copy link

algora-pbc bot commented Sep 19, 2023

🎉🎈 @neo773 has been awarded $200! 🎈🎊

@samejr
Copy link
Member

samejr commented Sep 19, 2023

Hey @neo773 thanks for working on this issue. I'm going to close this PR now as we need to rework some more things before we can implement it, but i've paid the bounty in the meantime.

@samejr samejr closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants