Add Jira target docs #100
Add Jira target docs #100
Conversation
| The Jira target accepts these event types: | ||
|
|
||
| - `com.jira.issue/create` | ||
|
|
There was a problem hiding this comment.
Those slashes are quite inconsistent with everything we've done so far. No saying that's not a good pattern, but I'd really love to see us agree on one consistent pattern, and only then apply it across the board instead of this brute force. Too late to revert and discuss, I imagine?
There was a problem hiding this comment.
The target is merged.
We can open a ticket for accepted event types naming at targets or misc.
There was a problem hiding this comment.
Are we still going with com.jira.issue.create? I thought you had merged the target with io.triggermesh.jira.issue.create?
There was a problem hiding this comment.
Will hold off reviewing until after https://github.com/triggermesh/knative-targets/pull/368 is addressed. However did notice some of the schema definitions need a newline at the end of the file.
@cab105 updated |
| The Jira target accepts these event types: | ||
|
|
||
| - `com.jira.issue/create` | ||
|
|
There was a problem hiding this comment.
Are we still going with com.jira.issue.create? I thought you had merged the target with io.triggermesh.jira.issue.create?
docs/targets/jira.md
Outdated
|
|
||
| Reply contains a a partially filled Jira issue with updated data. | ||
|
|
||
| - `com.jira.issue.get` |
There was a problem hiding this comment.
Same here for io.triggermesh.jira.issue.get
docs/targets/jira.md
Outdated
|
|
||
| Reply data contains a Jira issue. | ||
|
|
||
| - `com.jira.custom` |
There was a problem hiding this comment.
And here for io.triggermesh.jira.custom
Add Jira target docs.