Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

JeffNeff
Copy link
Contributor

Creates documentation to deploy a Twilio Source within Triggermesh.

@JeffNeff JeffNeff self-assigned this Jan 25, 2021
Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the rendering is off, by looking at the rendered page.

@JeffNeff
Copy link
Contributor Author

That's odd... let me check it in github's viewer. On the vs viewer it appeared fine.

@antoineco
Copy link
Contributor

Either you need new lines, or the relative paths to images is wrong, I think.

@JeffNeff
Copy link
Contributor Author

vs code does not mind '.png' while I guess github wants ".PNG"

@antoineco
Copy link
Contributor

That's probably because you run on Windows, and Windows is a case-insensitive OS :)

Do we need to make those extensions scream though? It would be more portable to keep them lowercase, and avoid that kind of weird side effects.

@antoineco antoineco self-requested a review January 26, 2021 22:29
Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have a duplicate of every PNG file.

Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering is still off. Some image links reference files with a .PNG (uppercase) extension, which don't exist.

@JeffNeff JeffNeff requested a review from antoineco February 18, 2021 21:50
Comment on lines 103 to 105
"from": "+19196878202",
"from_city": "DURHAM",
"to": "+12098301745",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask whose numbers those are but I think I know the answer already, so you can probably anticipate what has to be done: change to a dummy or to <redacted>.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

54b0947 redacts the phone numbers and the domain in use

Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving but please anonymize the phone numbers 😉

@sameersbn sameersbn merged commit 46c0dd9 into master Feb 23, 2021
@sameersbn sameersbn deleted the twiliosource branch February 23, 2021 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants