-
Notifications
You must be signed in to change notification settings - Fork 10
Creates Twilio Source docs #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the rendering is off, by looking at the rendered page.
That's odd... let me check it in github's viewer. On the vs viewer it appeared fine. |
Either you need new lines, or the relative paths to images is wrong, I think. |
vs code does not mind '.png' while I guess github wants ".PNG" |
That's probably because you run on Windows, and Windows is a case-insensitive OS :) Do we need to make those extensions scream though? It would be more portable to keep them lowercase, and avoid that kind of weird side effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have a duplicate of every PNG file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering is still off. Some image links reference files with a .PNG
(uppercase) extension, which don't exist.
docs/sources/twilio.md
Outdated
"from": "+19196878202", | ||
"from_city": "DURHAM", | ||
"to": "+12098301745", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to ask whose numbers those are but I think I know the answer already, so you can probably anticipate what has to be done: change to a dummy or to <redacted>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
54b0947 redacts the phone numbers and the domain in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving but please anonymize the phone numbers 😉
Creates documentation to deploy a Twilio Source within Triggermesh.