Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Update Sources to look like the template formatting #126 #134

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

thomasgilmore
Copy link
Contributor

@thomasgilmore thomasgilmore commented Apr 20, 2021

Changes

Updated the existing sources to look like the template that is supplied.

  • go to templates/source/sourceExample.md change Prerequisites to Prerequisite(s)
  • go to templates/source/sourceTemplate.md change Prerequisites to Prerequisite(s)
  • go through all of the sources in the folder sources and change the format to the template

Relates

closes #126

@thomasgilmore thomasgilmore marked this pull request as draft April 20, 2021 01:27
@thomasgilmore
Copy link
Contributor Author

@daceynolan please review when you have a chance. Thank you.

@thomasgilmore thomasgilmore marked this pull request as ready for review April 20, 2021 01:36
@daceynolan daceynolan self-requested a review April 20, 2021 01:40
@odacremolbap odacremolbap self-requested a review April 20, 2021 14:06
Copy link
Member

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution!!!

I apologize for the current state of our docs, some files are not part of our public docs, and are not linked from the index. You can either remove them, or we can create a followup issue to remove non linked docs and avoid people working on them.

I think the PR is almost ready for merging, left a couple comments.
The Salesforce Source is a tricky page, I couldn't get the numbering right, and it still doesn't seem to get the first numbers right (duplicated number 1). I'm not asking to fix that as part of this PR since it might need further investigation.

Thanks again, and if you feel you need more info or help, please ask.

@thomasgilmore
Copy link
Contributor Author

I made the above changes. Please let me know if there are anymore or if I missed something. Thank you.

Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you for this!

Turns out we did have more cases of * versus - than I imagined 😅

@antoineco antoineco requested a review from odacremolbap April 20, 2021 16:38
@antoineco antoineco merged commit 324b60d into triggermesh:master Apr 20, 2021
Copy link
Contributor

@daceynolan daceynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! This looks good to me. Thank you so much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Sources to look like the template formatting
4 participants