-
Notifications
You must be signed in to change notification settings - Fork 10
Create Rule Page #137
Create Rule Page #137
Conversation
@thomasgilmore95 your branch possibility needs to be rebased onto the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible 👍
Only one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like your rules state to use -
and not *
, but in the changes made it looks like the bullet lists were all changed to *
Do you mind changing these to -
?
@daceynolan the unrelated changes will automatically disappear when the branch gets rebased onto master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened but 32 modified files can't be right. Probably a broken rebase.
@antoineco Not really sure what happen with the broken rebase as well. Any tips on fixing it? |
On the command line that would be:
|
471e74d
to
4f05636
Compare
Not sure if this fixes things..... let me know?? Just wanted to let you know that I did fork the repo and I'm not sure if that changes things. my remote -v links are as follows for the project |
Ahhh then "origin" should have been "upstream". My bad. You may still be able to safely reapply the same commands though. |
4f05636
to
833c463
Compare
I used upstream now with the same commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! Thanks
Closes #136
Created Rules Page under template
Rules:
Use of - for bullets
Capital letter for TriggerMesh known elements like Bridges, Sources, Targets, use TriggerMesh and not Triggermesh.
Use 1. instead of 1. 2. 3. for lists.
Let me know if there should be any changes.