-
Notifications
You must be signed in to change notification settings - Fork 10
Updates Documentation for Sendgrid #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SendGrid, not Sendgrid.
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a draft, resolve all conversations and merge with a squash...
docs/targets/sendgrid.md
Outdated
|
||
```go | ||
"Notification from " + string(event.Source()) + " Knative Event" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would @cab105 or @antoineco (or anyone) mind providing me with a better "front facing" format to display how the subject is formatted/propagated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using ``` without the language specifier will work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While re-phrasing my question I came up with a way to write this that, i hope, is acceptable.
I tried to to a better job at explaining how things work and what things are needed/not needed. Save the examples section being provided with an actual example ( I can do this but I really want to move on so if we want this is it okay to open an issue for it and assign me to do after I finish |
docs/targets/sendgrid.md
Outdated
|
||
```go | ||
"Notification from " + string(event.Source()) + " Knative Event" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using ``` without the language specifier will work fine.
Co-authored-by: Antoine Cotten <hello@acotten.com>
These updates will only be relevant post merge of FE PR -> https://github.com/triggermesh/frontend/pull/1116