Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Updates Documentation for Sendgrid #36

Merged
merged 26 commits into from
Sep 22, 2020
Merged

Conversation

JeffNeff
Copy link
Contributor

@JeffNeff JeffNeff commented Aug 6, 2020

These updates will only be relevant post merge of FE PR -> https://github.com/triggermesh/frontend/pull/1116

@JeffNeff JeffNeff self-assigned this Aug 6, 2020
Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SendGrid, not Sendgrid.

@JeffNeff JeffNeff requested review from cab105 and antoineco August 10, 2020 01:56
sebgoa and others added 7 commits August 10, 2020 14:17
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
Co-authored-by: Antoine Cotten <hello@acotten.com>
@JeffNeff JeffNeff marked this pull request as draft August 10, 2020 15:39
Copy link
Member

@sebgoa sebgoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a draft, resolve all conversations and merge with a squash...


```go
"Notification from " + string(event.Source()) + " Knative Event"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would @cab105 or @antoineco (or anyone) mind providing me with a better "front facing" format to display how the subject is formatted/propagated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using ``` without the language specifier will work fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While re-phrasing my question I came up with a way to write this that, i hope, is acceptable.

Ref -> https://github.com/triggermesh/docs/blob/d8b6f0997c3776d5bc6539f267c901d1ced5d4e9/docs/targets/sendgrid.md#example

@JeffNeff
Copy link
Contributor Author

I tried to to a better job at explaining how things work and what things are needed/not needed. Save the examples section being provided with an actual example ( I can do this but I really want to move on so if we want this is it okay to open an issue for it and assign me to do after I finish event-sources?

@JeffNeff JeffNeff marked this pull request as ready for review August 10, 2020 18:22
@JeffNeff JeffNeff requested review from sebgoa and antoineco August 10, 2020 18:22

```go
"Notification from " + string(event.Source()) + " Knative Event"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using ``` without the language specifier will work fine.

@JeffNeff JeffNeff requested a review from cab105 August 10, 2020 19:36
@JeffNeff JeffNeff dismissed antoineco’s stale review August 10, 2020 19:39

Thank you!! You are a Rockstar!

@JeffNeff JeffNeff merged commit a3c031f into master Sep 22, 2020
@JeffNeff JeffNeff deleted the origin/updates/sendgrid branch September 22, 2020 03:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants