This repository was archived by the owner on May 5, 2025. It is now read-only.
Update observability-metrics.md #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is very subjective, but for me, the issue we're solving with this update is rather on the "special case" side, so maybe we could make this warning less intrusive. We can simply mention it in the config snippet with a short explanation, like this: 
Explanation wording can be changed if you have something better in mind. Or we can uncomment those two lines, it shouldn't break anything. What do you think? |
|
Sure! I like it. I'll make that change and add the function examples too. |
|
Maybe we can merge this PR and do the function stuff in another one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning for users installing Prometheus using the Operator.