-
Notifications
You must be signed in to change notification settings - Fork 10
#33 - Follow MLA guidelines for capitalization of titles #69
Conversation
perfect. those seemingly small things and attention to details are highly appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking at this. Found one nit and an unrelated nit. Otherwise, looks good.
@@ -17,7 +17,7 @@ You will need: | |||
- [Subscribe to Slack Events](#subscribe-to-slack-events) | |||
- [Testing the Integration](#testing-the-integration) | |||
|
|||
## Create Confluent user | |||
## Create Confluent User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the way the ToC is generated, you will need to modify L14 to ensure the case matches as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this :)
docs/tm/registry.md
Outdated
|
||
Docker images are used to run functions code in Knative services. This means that image registry is important part of service deployment scheme. Depending on type of service, Knative controller may either only pull or also push service image from and to registry. Triggermesh CLI provides simple configuration interface to setup registry address and user access credentials. | ||
|
||
### Service from pre-build image | ||
### Service from Pre-Build Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to the capitalization issue, but this should be Pre-Built
instead of Pre-Build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :) I changed this
rebased, merging... |
Change all titles to follow MLA guidelines.
closes #33