Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

daceynolan
Copy link
Contributor

Change all titles to follow MLA guidelines.

closes #33

@daceynolan daceynolan self-assigned this Nov 11, 2020
@daceynolan daceynolan requested a review from sebgoa November 11, 2020 16:02
@sebgoa
Copy link
Member

sebgoa commented Nov 11, 2020

perfect.

those seemingly small things and attention to details are highly appreciated

Copy link
Contributor

@cab105 cab105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this. Found one nit and an unrelated nit. Otherwise, looks good.

@@ -17,7 +17,7 @@ You will need:
- [Subscribe to Slack Events](#subscribe-to-slack-events)
- [Testing the Integration](#testing-the-integration)

## Create Confluent user
## Create Confluent User
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the way the ToC is generated, you will need to modify L14 to ensure the case matches as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this :)


Docker images are used to run functions code in Knative services. This means that image registry is important part of service deployment scheme. Depending on type of service, Knative controller may either only pull or also push service image from and to registry. Triggermesh CLI provides simple configuration interface to setup registry address and user access credentials.

### Service from pre-build image
### Service from Pre-Build Image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to the capitalization issue, but this should be Pre-Built instead of Pre-Build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) I changed this

@daceynolan daceynolan requested a review from cab105 November 11, 2020 20:55
@sameersbn
Copy link
Contributor

rebased, merging...

@sameersbn sameersbn merged commit a613cb0 into master Nov 12, 2020
@sameersbn sameersbn deleted the dacey/33 branch November 12, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow MLA guidelines for capitalization of titles
4 participants