This repository was archived by the owner on Dec 11, 2023. It is now read-only.
Adding CA Certificate support to redis broker #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odacremolbap
approved these changes
Mar 23, 2023
Comment on lines
88
to
90
| resources.ContainerAddEnvVarFromSecret("REDIS_CA_CERTIFICATE", | ||
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Name, | ||
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Key)(c) |
There was a problem hiding this comment.
@coding-trees
Can we update the environment variable here?
Suggested change
| resources.ContainerAddEnvVarFromSecret("REDIS_CA_CERTIFICATE", | |
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Name, | |
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Key)(c) | |
| resources.ContainerAddEnvVarFromSecret("REDIS_TLS_CA_CERTIFICATE", | |
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Name, | |
| rb.Spec.Redis.Connection.CACertificate.SecretKeyRef.Key)(c) |
There was a problem hiding this comment.
yup, good catch. Updated.
odacremolbap
approved these changes
Mar 28, 2023
|
Thanks so much @coding-trees !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an optional
caCertificatefield for the scenarios where Redis requires a cert - address feature request outlined here: triggermesh/brokers#129