Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriBITS Snapshot update as of 2021-09-03 #9663

Commits on May 26, 2021

  1. Automatic snapshot commit from tribits at 74f61da

    Origin repo remote tracking branch: 'github/master'
    Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git'
    
    At commit:
    
    commit 74f61da9a7a97742e941585166025e849c6dcfaf
    Author:  Roscoe A. Bartlett <rabartl@sandia.gov>
    Date:    Wed May 26 16:56:22 2021 -0600
    Summary: Add link back to function call graph (trilinos#63)
    bartlettroscoe committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bd26a11 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Automatic snapshot commit from tribits at aeb746c

    Origin repo remote tracking branch: 'github/master'
    Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git'
    
    At commit:
    
    commit aeb746cc4499d9364807cb1b40fc366429bad06c
    Author:  Roscoe A. Bartlett <rabartl@sandia.gov>
    Date:    Thu Aug 26 06:40:10 2021 -0600
    Summary: Change internal TriBITS target_link_libraries() to PUBLIC (trilinos#299)
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2beb906 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'tribits_github_snapshot' into tribits-snapshot-2021-09-03

    Brings in numerous refactorings to TriBITS over the last 3 months, but there
    should be no breaks in backward compatibility.  Almost every file in TriBITS
    is changed due to the lower-casing of command, macro and function names in PR
    TriBITSPub/TriBITS#379.  But the main driver for this snapshot is to bring in
    the change in PR TriBITSPub/TriBITS#413 that should make it so that Kokkos
    INTERFACE_COMPILE_OPTIONS get propagated to downstream targets in TriBITS and
    therefore to external customers through installed <Package>Config.cmake files
    and IMPORTED targets.  I should have done several snapshots in the last few
    months and not done a big snapshot like this (but I have been testing with
    Trilinos locally along the way).
    
    Overall, this merge brings in changes from a bunch of TriBITS PRs including
    (from most recent):
    
    * TriBITSPub/TriBITS#413: Change internal TriBITS target_link_libraries() to
      PUBLIC (TriBITSPub/TriBITS#299) component: core type: enhancement
    
    * TriBITSPub/TriBITS#410: Upgrade from cmake 3.21.0 to 3.21.2
      (TriBITSPub/TriBITS#363, TriBITSPub/TriBITS#394)
    
    * TriBITSPub/TriBITS#394: DO NOT MERGE: Show TriBITS test failures with CMake
      3.21.0 that don't occur with CMake 3.17.5 (TriBITSPub/TriBITS#363)
    
    * TriBITSPub/TriBITS#409: Add getTestDictStatusField() to handle empty
      'status' field (SESW-383) component: ci_support type: enhancement
    
    * TriBITSPub/TriBITS#408: Deal with spaces in CDash url parts (SESW-383)
      component: ci_support type: enhancement
    
    * TriBITSPub/TriBITS#403: Spelling fixes
    
    * TriBITSPub/TriBITS#407: Move tribits_get_build_url_and_write_to_file() to
      stand-alone module (TriBITSPub/TriBITS#154) component: ctest_driver type:
      enhancement
    
    * TriBITSPub/TriBITS#388: Fixing typos (TriBITSPub/TriBITS#377)
    
    * TriBITSPub/TriBITS#406: Fix tribits_ctest_driver() package-by-package mode
      for CMake 3.19+ (TriBITSPub/TriBITS#363, TriBITSPub/TriBITS#394) component:
      ctest_driver type: bug
    
    * TriBITSPub/TriBITS#401: Improve GitHub Actions and CDash integration
      (TriBITSPub/TriBITS#154) type: enhancement
    
    * TriBITSPub/TriBITS#366: CI: draft action yaml
    
    * TriBITSPub/TriBITS#402: Revert some incorrect uppercase->lowercase changes
    
    * TriBITSPub/TriBITS#387: Build and deploy TriBITS documentation with Sphinx
      (TriBITSPub/TriBITS#386) component: documentation type: enhancement
    
    * TriBITSPub/TriBITS#398: Deal with pr null in not preprending build name
      (TriBITSPub/TriBITS#363) type: bug
    
    * TriBITSPub/TriBITS#396: Send PR results to 'Pull Request' CDash group and
      add PR ID to build names (TriBITSPub/TriBITS#363) type: enhancement
    
    * TriBITSPub/TriBITS#397: Print the ninja path and version
      (TriBITSPub/TriBITS#363)
    
    * TriBITSPub/TriBITS#393: GitHub Actions based testing for TriBITS
      (TriBITSPub/TriBITS#363) type: enhancement
    
    * TriBITSPub/TriBITS#389: TriBITS CI testing with GitHub Actions
      (TriBITSPub/TriBITS#363) type: enhancement
    
    * TriBITSPub/TriBITS#392: Fix broken tests for non-Fortran and CMake 3.21
      builds (TriBITSPub/TriBITS#363) component: core
    
    * TriBITSPub/TriBITS#391: Fix up build_docs.sh for Sphinx doc generation
      (TriBITSPub/TriBITS#386) component: documentation type: enhancement
    
    * TriBITSPub/TriBITS#390: Add test for doc generation and fix usage of Python3
      component: documentation type: bug
    
    * TriBITSPub/TriBITS#385: Replace last few references to
      TribitsDevelopersGuide.html (TriBITSPub/TriBITS#381) component:
      documentation type: enhancement
    
    * TriBITSPub/TriBITS#384: Split TribitsDevelopersGuide.* into
      TribitsUsersGuide.* and TribitsMaintainersGuide.* (TriBITSPub/TriBITS#381)
      component: documentation type: enhancement
    
    * TriBITSPub/TriBITS#383: Remove endfunction(<string>) and endmacro(<string>)
      (TriBITSPub/TriBITS#274, TriBITSPub/TriBITS#382) component: common_tpls
      type: bug
    
    * TriBITSPub/TriBITS#380: More package-arch data-structure documentation
      updates (TriBITSPub/TriBITS#63) component: documentation type: enhancement
    
    * TriBITSPub/TriBITS#379: Convert TriBITS to lower-case CMake command, macro,
      and function names (TriBITSPub/TriBITS#274)
    
    The following files were conflicting where I went with what is on the Trilinos
    'develop' branch:
    
    * cmake/tribits/common_tpls/FindTPLBLAS.cmake
    * cmake/tribits/common_tpls/FindTPLLAPACK.cmake
    * cmake/tribits/common_tpls/FindTPLNetcdf.cmake
    
    (It looks like the above changes never made it back into TriBITS proper.  The
    conflicts were due to the case changes in cmake command calls in these files
    due to TriBITSPub/TriBITS#379.)
    
    There was also a conflict in the file:
    
    * cmake/tribits/core/installation/TribitsProjectConfigTemplate.cmake.in
    
    I looked at that one carefully and I think that may have been due to fixes on
    both sides and then the case changes from TriBITSPub/TriBITS#379.
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    3c77011 View commit details
    Browse the repository at this point in the history
  3. Fix misspelling of cache var type 'STRING'

    I noticed this while looking at another issue.
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6d9580a View commit details
    Browse the repository at this point in the history
  4. Sacado: There is no such thing as an 'INTEGER' CMake cache var type

    CMake 3.17 warns this is converted, implicity, to type 'STRING'.  There is no
    such thing as an 'INTEGER' CMake cache var type.  No reason to pretend there
    is.
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5088b69 View commit details
    Browse the repository at this point in the history
  5. Sacado: Add PUBLIC to raw target_link_libraries()

    Now that TriBITS uses explicit PUBLIC by default for target_link_libraries(),
    CMake 3.17.1 generates an error if you don't add a visibility specifier for
    this linkage.  Private seems like the correct linkage.
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0e4c611 View commit details
    Browse the repository at this point in the history
  6. Make the default SEMS env GCC 7.2.0 like PR testing

    Trilinos now requires GCC 7.2.0 as the minimum GCC version.  In fact, there is
    a Sacado file that cashes GCC 5.3.0 so you can't use that compiler with Sacado
    anymore.
    bartlettroscoe committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    bdc56f5 View commit details
    Browse the repository at this point in the history