Skip to content

Add Airlift JMX modules #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Add Airlift JMX modules #164

merged 1 commit into from
Jan 21, 2025

Conversation

andythsu
Copy link
Member

@andythsu andythsu commented Jan 11, 2025 •
edited
Loading

This exposes JMX metrics at /metrics

@cla-bot cla-bot bot added the cla-signed label Jan 11, 2025
Randgalt
Randgalt reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@Randgalt Randgalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this automatically do something? Or is there another PR coming after this?

@andythsu
Copy link
Member Author

andythsu commented Jan 17, 2025 •
edited
Loading

Does this automatically do something? Or is there another PR coming after this?

It automatically exposes metrics to /metrics endpoint
The metrics it exposes include (but not limited to)

  • http server threads usage
  • http client request, response time
  • jvm metrics

They come for free from Airlift

We are planning to add some more useful metrics as it fits. For example:

  • time it takes to talk to OPA
  • time it takes to fetch credentials
  • time it takes to sign a request
    ...

These will come in subsequent PRs

@mosiac1 mosiac1 merged commit da51b88 into trinodb:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Randgalt Randgalt Randgalt approved these changes

@mosiac1 mosiac1 mosiac1 approved these changes

@vagaerg vagaerg Awaiting requested review from vagaerg

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andythsu @Randgalt @mosiac1