Introduce Glue protocol module #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randgalt
force-pushed
the
jordanz/glue
branch
6 times, most recently
from
28f0b05 to
e0bc180
Compare
Randgalt
force-pushed
the
jordanz/refactor
branch
from
763cdce to
09d5c7f
Compare
Randgalt
force-pushed
the
jordanz/glue
branch
from
e0bc180 to
8537302
Compare
Randgalt
force-pushed
the
jordanz/refactor
branch
3 times, most recently
from
4cb1617 to
21ef861
Compare
Randgalt
force-pushed
the
jordanz/glue
branch
from
8537302 to
5e6c612
Compare
mosiac1
requested changes
Jan 30, 2025
trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest/ModelLoader.java
Outdated
Show resolved
Hide resolved
trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/TrinoGlueModule.java
Show resolved
Hide resolved
trino-aws-proxy/src/main/java/io/trino/aws/proxy/server/rest/ResourceSecurity.java
Outdated
Show resolved
Hide resolved
trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/TrinoStandaloneGlueModule.java
Show resolved
Hide resolved
trino-aws-proxy-spi/src/main/java/io/trino/aws/proxy/spi/signing/SigningServiceType.java
Outdated
Show resolved
Hide resolved
trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest/SerializerCommon.java
Outdated
Show resolved
Hide resolved
Randgalt
force-pushed
the
jordanz/glue
branch
from
5e6c612 to
b388c07
Compare
New module that implements a Glue REST API endpoint allowing Glue proxying/emulation. - Adds serializers/deserializers for all Glue models - Glue REST endpoint that marshals request payloads - Injectable request handler - Could be the basis of a Glue proxy, though this isn't implemented currently - Can be run as a standalone Glue endpoint handler - Can be add Glue endpoint to AWS S3 proxy as standard plugin
Randgalt
force-pushed
the
jordanz/glue
branch
from
b388c07 to
35283c4
Compare
mosiac1
reviewed
Jan 30, 2025
trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest/ModelLoader.java
Show resolved
Hide resolved
| { | ||
| requestLoggingSession.logProperty("request.glue.emulated.key", signingMetadata.credentials().emulated().secretKey()); | ||
|
|
||
| String target = request.requestHeaders().unmodifiedHeaders().getFirst("x-amz-target") |
There was a problem hiding this comment.
I am not familiar with Glue, but it seems x-amz-target is not documented.
Does Glue do something like graphql, using only 1 path and setting the action/request with this header?
There was a problem hiding this comment.
I determined this ad-hoc by running tests with the AWS CLI and the Glue Java client. I'll try to find some doc for it.
There was a problem hiding this comment.
You can see it in the Javascript code. https://github.com/aws/aws-sdk-js/blob/966fa6c316dbb11ca9277564ff7120e6b16467f4/lib/protocol/json.js#L26
There was a problem hiding this comment.
Then, here is the "api" for Glue. Notice is all POST: https://github.com/aws/aws-sdk-js/blob/master/apis/glue-2017-03-31.normal.json. And the protocol:
"protocols": [
"json"
],
There was a problem hiding this comment.
Interesting. I guess if it works it works
mosiac1
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New module that implements a Glue REST API endpoint allowing Glue proxying/emulation.
ReadMe: https://github.com/trinodb/aws-proxy/blob/jordanz/glue/trino-aws-proxy-glue/README.md