Skip to content

Make Cursor implement iterable #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

Make Cursor implement iterable #35

merged 1 commit into from
Jul 7, 2020

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Jun 30, 2020

Fixes #33.

@cla-bot cla-bot bot added the cla-signed label Jun 30, 2020
@hashhar
Copy link
Member Author

hashhar commented Jun 30, 2020

Tests are pending.

Also, the current impl ends up delegating to PrestoResult::__iter__ which means that it's somewhat lazily evaluated.

@hashhar
Copy link
Member Author

hashhar commented Jun 30, 2020 •
edited
Loading

Existing tests are failing because co-ordinator was unable to start within 180 seconds on Travis. Tests are working locally though.

The docker run in integration_tests/fixtures.py ends up pulling the images and is unable to finish in <180s in some cases.

@hashhar hashhar marked this pull request as ready for review July 6, 2020 16:20
@hashhar hashhar requested a review from findepi July 6, 2020 16:56
findepi
findepi approved these changes Jul 7, 2020
View reviewed changes
@findepi findepi merged commit 20dca30 into trinodb:master Jul 7, 2020
@findepi
Copy link
Member

findepi commented Jul 7, 2020

Merged, thanks!

@hashhar hashhar deleted the hashhar/iterable-cursor branch July 7, 2020 20:42
@findepi
Copy link
Member

findepi commented Oct 1, 2020

Released in 0.301.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

Assignees

No one assigned

Labels

cla-signed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cursor should implement __iter__

2 participants

@hashhar @findepi