-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Upgrade Oracle docker image for testing to oracle-free 23 #26573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7930a64
to
f219338
Compare
f219338
to
54133ed
Compare
Hmm... Extending the startup timeout could improve stability? Let me try. |
54133ed
to
5db2e67
Compare
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
1257afa
to
ee9a821
Compare
c644d9d
to
8d646b8
Compare
Extending the startup timeout was effective. Oracle test cases are now much more stable. |
Could you add a temporary commit to run stress tests, similar to #26587? |
Upload test results have failed due to conflict. Tests alone look fine :) |
Yeah, Maven Tests passed without errors in all attempts: I will remove the test commit and clean up the PR. |
34f6f84
to
875c23c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we can handle #5901 as a follow-up.
875c23c
to
9305634
Compare
@wendigo Please don't merge this PR yet. There was CI failure before the last force-push. https://github.com/trinodb/trino/actions/runs/18179150351/job/51751480568 |
Description
Upgrade Oracle docker image for testing from oracle-xe 11 to oracle-free 23.
This will also allow us to run Oracle connector test cases on Apple Silicon Mac as oracle-free has arm64 image while oracle-xe doesn't.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.