Skip to content

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Sep 7, 2025

Description

Upgrade Oracle docker image for testing from oracle-xe 11 to oracle-free 23.

This will also allow us to run Oracle connector test cases on Apple Silicon Mac as oracle-free has arm64 image while oracle-xe doesn't.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 7, 2025
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver oracle Oracle connector labels Sep 7, 2025
@takezoe takezoe force-pushed the oracle-free-23 branch 2 times, most recently from 7930a64 to f219338 Compare September 7, 2025 13:38
@takezoe takezoe marked this pull request as ready for review September 8, 2025 00:54
@github-actions github-actions bot added the docs label Sep 8, 2025
ebyhr
ebyhr previously approved these changes Sep 8, 2025
@ebyhr ebyhr dismissed their stale review September 8, 2025 06:24

It seems flakier than before.

@takezoe
Copy link
Member Author

takezoe commented Sep 8, 2025

Error: TestOracleCastPushdown>AbstractTestQueryFramework.init:119->createQueryRunner:50 » ContainerLaunch Container startup failed for image gvenzl/oracle-free:23.9-slim
Error: TestOracleQueryFailureRecoveryTest>AbstractTestQueryFramework.init:119->BaseFailureRecoveryTest.createQueryRunner:107->BaseOracleFailureRecoveryTest.createQueryRunner:45 » ContainerLaunch Container startup failed for image gvenzl/oracle-free:23.9-slim

Hmm... Extending the startup timeout could improve stability? Let me try.

Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Sep 29, 2025
@takezoe takezoe force-pushed the oracle-free-23 branch 2 times, most recently from 1257afa to ee9a821 Compare September 30, 2025 01:23
@github-actions github-actions bot removed the stale label Sep 30, 2025
@takezoe
Copy link
Member Author

takezoe commented Oct 1, 2025

Extending the startup timeout was effective. Oracle test cases are now much more stable.

@ebyhr
Copy link
Member

ebyhr commented Oct 1, 2025

Could you add a temporary commit to run stress tests, similar to #26587?

@wendigo
Copy link
Contributor

wendigo commented Oct 1, 2025

Upload test results have failed due to conflict. Tests alone look fine :)

@takezoe
Copy link
Member Author

takezoe commented Oct 2, 2025

Yeah, Maven Tests passed without errors in all attempts:
https://github.com/trinodb/trino/actions/runs/18166480223/job/51710161057?pr=26573

I will remove the test commit and clean up the PR.

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can handle #5901 as a follow-up.

@ebyhr
Copy link
Member

ebyhr commented Oct 2, 2025

@wendigo Please don't merge this PR yet. There was CI failure before the last force-push. https://github.com/trinodb/trino/actions/runs/18179150351/job/51751480568

@ebyhr ebyhr merged commit e53291d into trinodb:master Oct 2, 2025
6 of 16 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs jdbc Relates to Trino JDBC driver oracle Oracle connector
Development

Successfully merging this pull request may close these issues.

3 participants