Add tests to TestRowBlock #26706
Merged
Add tests to TestRowBlock #26706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
reviewed
Sep 25, 2025
| List<Object>[] testRows = generateTestRows(fieldTypes, 5); | ||
| RowBlock rowBlock = (RowBlock) createBlockBuilderWithValues(fieldTypes, testRows).build(); | ||
|
|
||
| int[] positions = {0, 2, 4}; |
There was a problem hiding this comment.
Nit: these can be inlined into the copyPositions calls since they're not referenced afterwards.
| // Test with nulls | ||
| List<Object>[] testRowsWithNulls = alternatingNullValues(generateTestRows(fieldTypes, 3)); | ||
| RowBlock rowBlockWithNulls = (RowBlock) createBlockBuilderWithValues(fieldTypes, testRowsWithNulls).build().getRegion(1, testRowsWithNulls.length - 1); | ||
| int[] positions2 = {0, 2}; |
|
|
||
| // Test empty positions | ||
| int[] emptyPositions = {}; | ||
| RowBlock emptyBlock = rowBlock.copyPositions(emptyPositions, 0, 0); |
| RowBlock regionBlock = largerBlock.getRegion(1, 2); | ||
| RowBlock offsetAppendedBlock = regionBlock.copyWithAppendedNull(); | ||
| assertThat(offsetAppendedBlock.getPositionCount()).isEqualTo(3); | ||
| for (int i = 0; i < 2; i++) { |
There was a problem hiding this comment.
Probably unnecessary to assert these in a two-iteration loop, just unroll them this into two separate assertions.
SongChujun
force-pushed
the
rowblock_copyWithAppendedNull_fix
branch
from
9314230 to
4516abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add more tests to TestRowBlock
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: