Skip to content

Fix suite-compatibility for Trino 477 #26712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Fix suite-compatibility for Trino 477 #26712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38775e1
Fix suite-compatibility for Trino 477
wendigo Sep 25, 2025
76fc478
Clarify the actual option that needs to be passed
wendigo Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ private String getConfigFileFor(String dockerImage)
if (getVersionFromDockerImageName(dockerImage) < 369) {
return "config-pre369.properties";
}
if (getVersionFromDockerImageName(dockerImage) >= 477) {
return "config-post477.properties";
}
return "config.properties";
}

Expand Down Expand Up @@ -158,8 +161,8 @@ private static class Config

public Config(Map<String, String> extraOptions)
{
this.compatibilityTestVersion = parseInt(requireNonNull(extraOptions.get(TEST_DOCKER_VERSION), () -> format("Required extra option %s is null", TEST_DOCKER_VERSION)));
this.compatibilityTestDockerImage = requireNonNull(extraOptions.get(TEST_DOCKER_IMAGE), () -> format("Required extra option %s is null", TEST_DOCKER_IMAGE));
this.compatibilityTestVersion = parseInt(requireNonNull(extraOptions.get(TEST_DOCKER_VERSION), () -> format("Required extra option compatibility.%s is null", TEST_DOCKER_VERSION)));
this.compatibilityTestDockerImage = requireNonNull(extraOptions.get(TEST_DOCKER_IMAGE), () -> format("Required extra option compatibility.%s is null", TEST_DOCKER_IMAGE));
}

public int getCompatibilityTestVersion()
Expand Down
14 changes: 14 additions & 0 deletions ...r/trino-product-tests/conf/environment/singlenode-compatibility/config-post477.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
coordinator=true
node-scheduler.include-coordinator=true
http-server.http.port=8081
query.max-memory=2GB
query.max-memory-per-node=1.25GB
discovery-server.enabled=true
discovery.type=airlift_discovery
discovery.uri=http://compatibility-test-coordinator:8081

catalog.management=dynamic

# Reduce the amount of memory used by the finished queries and task info cache
query.min-expire-age=1m
task.info.max-age=1m
Loading