Fix batch size condition in AsyncResultIterator #26728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a batch size condition in AsyncResultIterator that was preventing proper batching of rows. The change corrects the logic to ensure rows are processed in batches of the specified BATCH_SIZE.
- Changed the batch size check from modulo operation to equality comparison
- Fixed row batching behavior to properly reset after reaching BATCH_SIZE
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
client/trino-jdbc/src/main/java/io/trino/jdbc/AsyncResultIterator.java
Outdated
Show resolved
Hide resolved
Previously, rows were not handled in batch
chenjian2664
force-pushed
the
simplfy_result_iterator
branch
from
9a29d59 to
8212c93
Compare
wendigo
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, rows were not handled in batch
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: