Skip to content

Allow reusing SingleStore container #26734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Allow reusing SingleStore container #26734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/trino-singlestore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-testing-containers</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-testing-services</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion ...n/trino-singlestore/src/test/java/io/trino/plugin/singlestore/SingleStoreQueryRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public DistributedQueryRunner build()
queryRunner.installPlugin(new SingleStorePlugin());
queryRunner.createCatalog("singlestore", "singlestore", connectorProperties);

queryRunner.execute("CREATE SCHEMA tpch");
queryRunner.execute("CREATE SCHEMA IF NOT EXISTS tpch");
copyTpchTables(queryRunner, "tpch", TINY_SCHEMA_NAME, initialTables);

return queryRunner;
Expand Down
20 changes: 19 additions & 1 deletion ...trino-singlestore/src/test/java/io/trino/plugin/singlestore/TestingSingleStoreServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,17 @@
import org.testcontainers.containers.JdbcDatabaseContainer;
import org.testcontainers.utility.DockerImageName;

import java.io.Closeable;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Set;

import static io.trino.testing.containers.TestContainers.startOrReuse;

public class TestingSingleStoreServer
extends JdbcDatabaseContainer<TestingSingleStoreServer>
{
Expand All @@ -33,6 +38,8 @@ public class TestingSingleStoreServer

public static final Integer SINGLESTORE_PORT = 3306;

private final Closeable cleanup;

public TestingSingleStoreServer()
{
this(DEFAULT_VERSION);
Expand All @@ -43,7 +50,7 @@ public TestingSingleStoreServer(String version)
super(DockerImageName.parse(DEFAULT_TAG));
addEnv("ROOT_PASSWORD", "memsql_root_password");
addEnv("SINGLESTORE_VERSION", version);
start();
cleanup = startOrReuse(this);
}

@Override
Expand Down Expand Up @@ -89,6 +96,17 @@ public String getTestQueryString()
return "SELECT 1";
}

@Override
public void close()
{
try {
cleanup.close();
}
catch (IOException e) {
throw new UncheckedIOException(e);
}
}

public void execute(String sql)
{
execute(sql, getUsername(), getPassword());
Expand Down