Skip to content

Conversation

ignitz
Copy link
Contributor

@ignitz ignitz commented Sep 29, 2025

Description

  • Fix default values from Trino 477 and Docs.
  • Fix typo.

The most important is pinot.prefer-broker-queries because change most of everything between Trino and Pinot.

Additional context and related issues

To get the default values in Runtime.

mkdir -pv catalog
cat > catalog/pinot.properties <<EOF
connector.name=pinot
pinot.controller-urls=http://pinot-controller:9000
EOF
docker run --rm -it -v ${PWD}/catalog:/etc/trino/catalog --name trino trinodb/trino:477 | grep -E "PROPERTY|pinot\."
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	PROPERTY                                               DEFAULT                                                                    RUNTIME                                                                    DESCRIPTION
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.https.automatic-shared-secret        [REDACTED]                                                                 [REDACTED]
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.use-blocking-connect                 false                                                                      false
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.connect-timeout                      300.00s                                                                    300.00s
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.destination-idle-timeout             1.00m                                                                      1.00m
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http2.enabled                        false                                                                      false                                                                      Enable the HTTP/2 transport
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http2.session-receive-window-size    16MB                                                                       16MB                                                                       Initial size of session's flow control receive window for HTTP/2
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http2.stream-receive-window-size     16MB                                                                       16MB                                                                       Initial size of stream's flow control receive window for HTTP/2
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http2.input-buffer-size              8kB                                                                        8kB                                                                        Size of the buffer used to read from the network for HTTP/2
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http-proxy                           ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http-proxy.password                  [REDACTED]                                                                 [REDACTED]
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http-proxy.user                      ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.https.excluded-cipher                [^.*_(MD5|SHA|SHA1)$, ^TLS_RSA_.*$, ^SSL_.*$, ^.*_NULL_.*$, ^.*_anon_.*$]  [^.*_(MD5|SHA|SHA1)$, ^TLS_RSA_.*$, ^SSL_.*$, ^.*_NULL_.*$, ^.*_anon_.*$]  Setting this config property overwrites Jetty's default excluded cipher suites
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.https.included-cipher                []                                                                         []
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.idle-timeout                         300.00s                                                                    300.00s
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.key-store-password                   [REDACTED]                                                                 [REDACTED]
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.key-store-path                       ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.buffer-size                      1MB                                                                        1MB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.compression.enabled              true                                                                       true
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.enabled                          false                                                                      false
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.flush-interval                   10.00s                                                                     10.00s
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.max-history                      15                                                                         15
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.max-size                         1GB                                                                        1GB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.path                             var/log/                                                                   var/log/                                                                   The name of the log file will be prefixed with the name of the HTTP client (<client_name>-http-client.log)
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.log.queue-size                       10000                                                                      10000
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-connections-per-server           250                                                                        250
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-content-length                   32MB                                                                       32MB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-direct-memory                    ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-heap-memory                      ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-request-header-size              8kB                                                                        8kB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-requests-queued-per-destination  1024                                                                       1024
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-response-header-size             16kB                                                                       16kB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.max-threads                          200                                                                        200
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.min-threads                          8                                                                          8
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.record-request-complete              true                                                                       true
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.request-buffer-size                  4kB                                                                        4kB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.request-timeout                      300.00s                                                                    300.00s
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.response-buffer-size                 16kB                                                                       16kB
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.http-proxy.secure                    false                                                                      false
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.secure-random-algorithm              ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.selector-count                       10                                                                         10
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.socks-proxy                          ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.tcp-keep-alive-idle-time             ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.timeout-concurrency                  4                                                                          4                                                                          Number of concurrent locks for timeout
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.timeout-threads                      8                                                                          8                                                                          Total number of timeout threads
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.trust-store-password                 [REDACTED]                                                                 [REDACTED]
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.trust-store-path                     ----                                                                       ----
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.http-client.https.hostname-verification          true                                                                       true                                                                       Verify that server hostname matches the server certificate
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.aggregation-pushdown.enabled                     true                                                                       true
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.broker-url                                       ----                                                                       ----                                                                       Provide global broker host and port. Setting this property will disable broker discovery mechanism.
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.connection-timeout                               1.00m                                                                      1.00m
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.controller-urls                                  []                                                                         [http://pinot-controller:9000]
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.count-distinct-pushdown.enabled                  true                                                                       true                                                                       Controls whether distinct count is pushed down to Pinot. Distinct count pushdown can cause Pinot to do a full scan. Aggregation pushdown must also be enabled in addition to this parameter otherwise no pushdowns will be enabled.
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.fetch-retry-count                                2                                                                          2
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.forbid-segment-queries                           false                                                                      false
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.max-rows-for-broker-queries                      50000                                                                      50000
2025-09-29T13:34:49.935Z	INFO	main	Bootstrap	pinot.metadata-expiry                                  2.00m                                                                      2.00m
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.non-aggregate-limit-for-broker-queries           25000                                                                      25000
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.prefer-broker-queries                            false                                                                      false
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.proxy.enabled                                    false                                                                      false
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.segments-per-split                               1                                                                          1
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.target-segment-page-size                         1MB                                                                        1MB
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.broker.authentication.type                       NONE                                                                       NONE
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.controller.authentication.type                   NONE                                                                       NONE
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.grpc.port                                        8090                                                                       8090
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.grpc.max-inbound-message-size                    134217728B                                                                 134217728B
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.max-rows-per-split-for-segment-queries           2147483646                                                                 2147483646
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.grpc.proxy-uri                                   ----                                                                       ----
2025-09-29T13:34:49.936Z	INFO	main	Bootstrap	pinot.grpc.use-plain-text                              true                                                                       true

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Sep 29, 2025
@github-actions github-actions bot added the docs label Sep 29, 2025
@wendigo
Copy link
Contributor

wendigo commented Sep 29, 2025

@ignitz please avoid merge commits - rebase instead.

@ignitz ignitz force-pushed the docs/pinot-fix-1 branch 2 times, most recently from 21a21d1 to 486670d Compare September 29, 2025 16:32
@ebyhr ebyhr merged commit e1a582f into trinodb:master Sep 29, 2025
4 of 9 checks passed
@github-actions github-actions bot added this to the 478 milestone Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants