Improve QueryId/TaskId handling #26769
Merged
+105
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
improve-taskid-handling
branch
from
d19344c to
844a94b
Compare
wendigo
changed the title
raunaqmorarka
approved these changes
Sep 30, 2025
wendigo
force-pushed
the
improve-taskid-handling
branch
from
844a94b to
5028e59
Compare
pettyjamesm
approved these changes
Sep 30, 2025
Avoids using inline regular expression parsing in favor of explicitly splitting on the character literal '.'. Also cleans up checkArgument lines to avoid varargs array allocations.
Previously, TaskId would split and re-parse each part of the identifier in methods like TaskId#getStageId or TaskId#getQueryId. This made those operations relatively more expensive but also meant that re-parsing and allocating a new QueryId instance occurred inside of each MemoryPool reservation operation- increasing the amount of time spent holding the memory pool lock.
wendigo
force-pushed
the
improve-taskid-handling
branch
from
5028e59 to
bd8e5ba
Compare
|
@wendigo Could you update "Release notes" section? |
ebyhr
reviewed
Oct 3, 2025
Comment on lines
+234
to
+241
| <ignore>true</ignore> | ||
| <code>java.method.visibilityReduced</code> | ||
| <old>method java.lang.String io.trino.spi.QueryId::validateId(java.lang.String)</old> | ||
| <new>method java.lang.String io.trino.spi.QueryId::validateId(java.lang.String, java.lang.String)</new> | ||
| <oldVisibility>public</oldVisibility> | ||
| <newVisibility>package</newVisibility> | ||
| <justification>Hidden method that is not used outside of QueryId</justification> | ||
| </item> |
There was a problem hiding this comment.
It is utility method used internally and while being a part of the SPI it is only used in trino-main so I don't think that it warrants a release note
There was a problem hiding this comment.
The internal usage is unrelated in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: