Skip to content

Conversation

koszti
Copy link
Member

@koszti koszti commented Oct 2, 2025

Description

Improve rendering performance of large query JSON code in Preview UI. Partially addressing #26724

Additional context and related issues

It removes react-syntax-highlighter in favor of monaco-editor. Monaco provides significantly better performance when rendering large JSON code and also offers several additional optional features such as code folding, minimap, sticky scroll, search bar and more.

image

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Improve rendering performance of large query JSON code in Preview UI. ({issue}`26807`)

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2025
@github-actions github-actions bot added the ui Web UI label Oct 2, 2025
@koszti koszti mentioned this pull request Oct 2, 2025
2 tasks
@wendigo
Copy link
Contributor

wendigo commented Oct 3, 2025

Woah. It's super fast :)

@wendigo wendigo merged commit 77529f3 into trinodb:master Oct 3, 2025
95 of 96 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 3, 2025
@koszti koszti deleted the fix-code-editor-performance branch October 3, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants