Use AccessControl functionality to filter columns from SELECT *… #9991

rodolfototaro · 2021-11-18T17:08:21Z

I Implemented the feature without modify the access control and making it configurable (by default is off).
The implementation allow also to create a rowfilter on a column that is inaccessible. This could be useful when you need to partition data between user but you would not to show the discrimination column.

fixes #7461

cla-bot · 2021-11-18T17:08:23Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

findepi · 2021-11-25T16:08:05Z

@rtotarocuebiq how does this PR relate to @youngchen7's #7893?

rodolfototaro · 2021-11-25T16:13:09Z

@findepi It is an alternative implementation that does not need to change the access control signature, so there is not an alternative method to "filterColumns". Moreover it cover the usecase when you need to partition data between user but you would not to show the discrimination column.

findepi · 2021-11-25T19:48:56Z

Moreover it cover the usecase when you need to partition data between user but you would not to show the discrimination column.

can you elaborate on that use-case, or exemplify?

rodolfototaro · 2021-11-25T20:14:07Z

Moreover it cover the usecase when you need to partition data between user but you would not to show the discrimination column.

can you elaborate on that use-case, or exemplify?

The need is to have columns that contain technical information related

to the owner of the data (tenant-id or user-id)
to the goal for which data can be used (related to data license)

so you want give access to a user just to a subset of data but at the same time you would not to show those columns to users. Will exist also users that have right for accessing to the whole table.
So you need to apply the row filters depending by logged user on inaccessibile columns.

findepi · 2021-11-26T08:33:53Z

So you need to apply the row filters depending by logged user on inaccessibile columns.

That's a reasonable requirement, and should be possible today, regardless of SELECT * expansion with respect to inaccessible columns.

@rtotarocuebiq do we have existing tests for that?
cc @kokosing

rodolfototaro · 2021-11-26T08:41:43Z

@findepi yes in core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java method testRowFilterOnNotAccessibleColumn

kokosing · 2021-11-29T08:44:34Z

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java

@@ -67,6 +67,7 @@
    public static final String QUERY_MAX_EXECUTION_TIME = "query_max_execution_time";
    public static final String QUERY_MAX_PLANNING_TIME = "query_max_planning_time";
    public static final String QUERY_MAX_RUN_TIME = "query_max_run_time";
+    public static final String QUERY_HIDE_INACCESSIBLE_COLUMNS = "query_hide_inaccessible_columns";


I don't think this should be exposed as a session property

any suggestions about?

@kokosing i understand you're concerned about the case where inaccessible columns are hidden with a config, but session property overrides and makes them visible (although still inaccessible) again. That would be a security problem

OTOH, i am thinking about the case where server uses default configuration, and user or group of users would want to leverage this new functionality. Providing session toggle would be nice.

I propose we do provide session toggle, but with validation preventing query_hide_inaccessible_columns be set to false, when config is true.

I think it is about the query semantic. I don't think user should be allowed to change what given query means at will. I think it may cause other issues. For example auditors may no longer know what give query means.

@kokosing I got your point, you prefer to set it at server config level. Can you give me suggestion on where add the property? (i.e. ServerConfig or AccessControlConfig) and which is the better way for accessing to the value from StatementAnalyzer ?

kokosing · 2021-11-29T08:45:13Z

core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java

+        return hideUnaccessibleColumns;
+    }
+
+    @Config("query.hide-inaccessible-columns")


@ConfigDescription

@Config("query.filter-restricted-columns")?

i like "hide" more.

also "restricted" could be understood as referring to inaccessible & masked columns, whereas we don't want to hide masked columns

core/trino-main/src/main/java/io/trino/sql/analyzer/Analysis.java

core/trino-main/src/main/java/io/trino/sql/analyzer/Analyzer.java

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

kokosing · 2021-12-02T09:20:39Z

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java

@@ -67,6 +67,7 @@
    public static final String QUERY_MAX_EXECUTION_TIME = "query_max_execution_time";
    public static final String QUERY_MAX_PLANNING_TIME = "query_max_planning_time";
    public static final String QUERY_MAX_RUN_TIME = "query_max_run_time";
+    public static final String QUERY_HIDE_INACCESSIBLE_COLUMNS = "query_hide_inaccessible_columns";


I think it is about the query semantic. I don't think user should be allowed to change what given query means at will. I think it may cause other issues. For example auditors may no longer know what give query means.

kokosing · 2021-12-02T09:23:28Z

core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java

+        tableColumnMap.asMap()
+                .forEach((key, value) -> {
+                    //Allow to create a rowfilter on a not accessibile column
+                    if (analysis.hasRowFilter(key, identity.getUser())) {


what about column masking?

I'm saving columns accessed via row filter for excluding them from the access control if them are not accessed also directly in the statement. I didn't see a similar usecase for masking. Do you have a specific use case in mind so that I can add a test about?

Yes. Consider a case where not accessible columns are used for column masking for example:

CASE not_accessible_column WHEN 'allowed' THEN actual_column WHEN 'masked' THEN mask(actual_column) ELSE null END

Please add tests for cases like that.

Ok, to support it I moved the filtering logic on io.trino.sql.analyzer.StatementAnalyzer.Visitor#analyzeRowFilter and io.trino.sql.analyzer.StatementAnalyzer.Visitor#analyzeColumnMask. Added test cases

kokosing · 2021-12-02T09:24:02Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

@@ -3188,6 +3189,26 @@ private void analyzeSelectAllColumns(
            }
        }

+        private List<Field> filterInaccessibleFields(List<Field> fields)
+        {
+            if (SystemSessionProperties.isHideInaccesibleColumns(session)) {


invert condition and remove else block (keyword)

rodolfototaro · 2021-12-04T09:54:48Z

I moved the property hide-inaccessible-columns on AccessControlConfig and aligned the pull request with master

kokosing · 2021-12-06T08:52:59Z

core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java

+        tableColumnMap.asMap()
+                .forEach((key, value) -> {
+                    //Allow to create a rowfilter on a not accessibile column
+                    if (analysis.hasRowFilter(key, identity.getUser())) {


Yes. Consider a case where not accessible columns are used for column masking for example:

CASE not_accessible_column WHEN 'allowed' THEN actual_column WHEN 'masked' THEN mask(actual_column) ELSE null END

Please add tests for cases like that.

kokosing · 2021-12-06T08:54:19Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                            field.getOriginColumnName().isEmpty() ||
+                                    field.getOriginTable().isEmpty() ||
+                                    field.isHidden() ||
+                                    !accessControl.filterInaccessibleColumns(


Let's define filterInaccessibleColumns in StatementAnalyzer. It seem that it is more semantic related thing than access.

kokosing · 2021-12-06T08:55:54Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                    .filter(field ->
+                            field.getOriginColumnName().isEmpty() ||
+                                    field.getOriginTable().isEmpty() ||
+                                    field.isHidden() ||


Why do you need above conditions? getVisibleFields already checks if field is hidden. Also I would prefer to avoid other conditions to as they may change semantic of how things work today.

ok, I removed the condition

kokosing · 2021-12-06T08:56:05Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

@@ -3188,6 +3188,21 @@ private void analyzeSelectAllColumns(
            }
        }

+        private List<Field> filterInaccessibleFields(List<Field> fields)
+        {
+            ImmutableList<Field> authorizedFields = fields.stream()


nit. inline authorizedFields

kokosing · 2021-12-06T08:56:51Z

core/trino-main/src/main/java/io/trino/security/AccessControlConfig.java

+        return hideInaccesibleColumns;
+    }
+
+    @Config("access-control.hide-inaccessible-columns")


Let's move it to FeaturesConfig and add @ConfigDescription

Ok, I moved it in FeaturesConfig and make accessibile in Metadata

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

kokosing · 2021-12-06T09:01:42Z

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

+        accessControl.deny(privilege("columns.data_type", SELECT_COLUMN));
+        // SHOW COLUMNS and DESCRIBE fail since data_type isn't visible
+        assertThatThrownBy(() -> assertions.query("SHOW COLUMNS FROM nation")).hasMessage("Access Denied: Cannot select from columns [ordinal_position, extra_info, table_schema, column_name, data_type, comment, table_name] in table or view local.information_schema.columns");
+        assertThatThrownBy(() -> assertions.query("DESCRIBE nation")).hasMessage("Access Denied: Cannot select from columns [ordinal_position, extra_info, table_schema, column_name, data_type, comment, table_name] in table or view local.information_schema.columns");


This query should not fail. If you are able to query table then surely you should be able to to DESCRIBE it. Columns that got hidden should be simply filtered here. Same comment for SHOW COLUMNS FROM nation

I added specific test for Describe and SHOW COLUMNS, this test check that are not accessible if I deny privilege on Information_schema

I don't get this test. You are revoking access to a metadata table which should be always accessible. I think it does not make sense. Please have tests where you only manipulate access on test tables like nation.

kokosing

I haven't put enough attention to analysis or statement analyzer yet. I would like first to reach a state where tests are expressing the thing we would like to have.

Notice that row filter and column masking is like a view, where the user given with it is like owner. We should still do access control checks for them. Please take a look how view access control works.

core/trino-main/src/main/java/io/trino/FeaturesConfig.java

kokosing · 2021-12-07T10:42:55Z

core/trino-main/src/main/java/io/trino/FeaturesConfig.java

+        return hideInaccesibleColumns;
+    }
+
+    @Config("experimental.hide-inaccessible-columns")


Why do you have experimental. here? I think this features is not going to affect a lot of users as it will be disabled by default so there should be no change for them.

kokosing · 2021-12-07T10:44:57Z

core/trino-main/src/main/java/io/trino/metadata/Metadata.java

+    /**
+     * Return true if columns must be hidden if inaccessible, default value is false
+     */
+    default boolean isHideInaccesibleColumns()


I think this simply belongs to StatementAnalyzer. It is about the syntax not metadata. Metadata is not changed when the toggle is enabled or not. We just handle it differently.

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

kokosing · 2021-12-07T10:51:48Z

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

+        accessControl.deny(privilege("columns.data_type", SELECT_COLUMN));
+        // SHOW COLUMNS and DESCRIBE fail since data_type isn't visible
+        assertThatThrownBy(() -> assertions.query("SHOW COLUMNS FROM nation")).hasMessage("Access Denied: Cannot select from columns [ordinal_position, extra_info, table_schema, column_name, data_type, comment, table_name] in table or view local.information_schema.columns");
+        assertThatThrownBy(() -> assertions.query("DESCRIBE nation")).hasMessage("Access Denied: Cannot select from columns [ordinal_position, extra_info, table_schema, column_name, data_type, comment, table_name] in table or view local.information_schema.columns");


I don't get this test. You are revoking access to a metadata table which should be always accessible. I think it does not make sense. Please have tests where you only manipulate access on test tables like nation.

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

rodolfototaro · 2021-12-07T17:49:11Z

I haven't put enough attention to analysis or statement analyzer yet. I would like first to reach a state where tests are expressing the thing we would like to have.

Notice that row filter and column masking is like a view, where the user given with it is like owner. We should still do access control checks for them. Please take a look how view access control works.

Thx for the suggestion I was misunderstanding the Identity meaning in the View Expression so now I simplified my PR a lot.

kokosing

It looks much better now. Actually no changes in analyzer.

core/trino-main/src/main/java/io/trino/FeaturesConfig.java

core/trino-main/src/main/java/io/trino/sql/analyzer/AnalyzerFactory.java

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

kokosing · 2021-12-09T12:19:16Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                return fields;
+            }
+            //collect fields by table
+            ListMultimap<QualifiedObjectName, Field> tableFieldsMap = Multimaps.newListMultimap(new HashMap<QualifiedObjectName, Collection<Field>>(), () -> new LinkedList<>());


Why is this that complex?

As I understand these fields always come from the same relation (maybe you do checkArgument to assert that), so do we need to use multimap here?

In case of join query like:
SELECT * FROM nation,customer WHERE customer.nationkey = nation.nationkey AND nation.name = 'FRANCE' AND customer.name='Customer#000001477'
I receive here fields from multiple tables

and in case of queries like:
SELECT * FROM (select 'test')
SELECT * FROM (SELECT concat(name,'-test') FROM nation WHERE name = 'FRANCE')

I receive fields without OriginaleTable/OriginaleColumn
so I must manage also those cases.

I'll add tests for that.

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

kokosing

Looks good, few minor comments. Thank you! Please rebase and squash commits. Make sure that commit message is well formatted and explains that change you are posting. Also please add this new property to the docs.

kokosing · 2021-12-10T11:00:21Z

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java

+    private static void validateHideInaccesibleColumns(boolean value, boolean defaultValue)
+    {
+        if (defaultValue == true && value == false) {
+            throw new TrinoException(INVALID_SESSION_PROPERTY, "hide_inaccessible_columns cannot be set to false if default value is true");


It is not much user friendly error message, it is very technical. Maybe:

hide_inaccessible_columns cannot be disabled with session property when it was enabled with configuration

Also use HIDE_INACCESSIBLE_COLUMNS constant

Please make sure you have tests for this.

kokosing · 2021-12-10T11:01:12Z

core/trino-main/src/test/java/io/trino/sql/query/TestFilterHideInacessibleColumnsSession.java

+                new NodeMemoryConfig(),
+                new DynamicFilterConfig(),
+                new NodeSchedulerConfig()));
+        Assertions.assertThatNoException().isThrownBy(() -> sessionPropertyManager.validateSystemSessionProperty(SystemSessionProperties.HIDE_INACCESSIBLE_COLUMNS, "true"));


static import?

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java

kokosing · 2021-12-10T11:06:58Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                Set<String> accessibleColumns = accessControl.filterColumns(
+                        session.toSecurityContext(),
+                        table.asCatalogSchemaTableName(),
+                        tableFields.stream().map(field -> field.getOriginColumnName().get()).collect(Collectors.toSet()));


please extract variable for column names, also please use toImmutableSet()

kokosing · 2021-12-10T11:07:10Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                        .collect(toImmutableList()));
+            });
+
+            //filter at the end for preserving the global order


remove the comment

kokosing

Please rebase and squash commits (FYI https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#git-merge-strategy)

kokosing · 2021-12-13T10:31:28Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+                Set<String> accessibleColumns = accessControl.filterColumns(
+                        session.toSecurityContext(),
+                        table.asCatalogSchemaTableName(),
+                        tableFields.stream().map(field -> field.getOriginColumnName().get()).collect(toImmutableSet()));


nit:

tableFields.stream() .map(field -> field.getOriginColumnName().get()) .collect(toImmutableSet()));

kokosing · 2021-12-13T10:33:57Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

+            List<Field> accessibleFields = new ArrayList<>();
+
+            //collect fields by table
+            ListMultimap<QualifiedObjectName, Field> tableFieldsMap = Multimaps.newListMultimap(new HashMap<QualifiedObjectName, Collection<Field>>(), () -> new LinkedList<>());


ListMultimap<QualifiedObjectName, Field> tableFieldsMap = ArrayListMultimap.create();

core/trino-main/src/main/java/io/trino/FeaturesConfig.java

kokosing · 2021-12-14T14:53:10Z

docs/src/main/sphinx/security/overview.rst

@@ -124,6 +124,18 @@ In addition, Trino :doc:`provides an API </develop/system-access-control>` that
 allows you to create a custom access control method, or to extend an existing


@mosabua Can you please double check wording in the docs here?

docs/src/main/sphinx/security/overview.rst

mosabua

Only reviewed for docs and suggested changes. Also need confirmation if this is a global property or a catalog property.

core/trino-main/src/main/java/io/trino/FeaturesConfig.java

docs/src/main/sphinx/security/overview.rst

With hide-inaccessible-columns configuration toggle now it is possible to exclude non accessible from SELECT * statement

kokosing · 2021-12-16T12:10:17Z

Merged, thank you!

rodolfototaro mentioned this pull request Nov 18, 2021

Extend AccessControl functionality to filter columns from SELECT * instead of throwing #7461

Closed

cla-bot bot added the cla-signed label Nov 23, 2021

rodolfototaro requested review from findepi and martint November 24, 2021 16:48

findepi changed the title ~~#7461 Use AccessControl functionality to filter columns from SELECT *…~~ Use AccessControl functionality to filter columns from SELECT *… Nov 25, 2021

kokosing reviewed Nov 29, 2021

View reviewed changes

kokosing mentioned this pull request Nov 29, 2021

Update StatementAnalyzer and extend AccessControl interface and to filter columns from table schema instead of throwing #7893

Closed

findepi reviewed Nov 29, 2021

View reviewed changes

core/trino-main/src/main/java/io/trino/SystemSessionProperties.java Outdated Show resolved Hide resolved

findepi reviewed Nov 29, 2021

View reviewed changes

core/trino-main/src/test/java/io/trino/sql/query/TestFilterInaccessibleColumns.java Outdated Show resolved Hide resolved

rodolfototaro requested review from findepi and kokosing December 1, 2021 06:56

kokosing reviewed Dec 2, 2021

View reviewed changes

kokosing reviewed Dec 6, 2021

View reviewed changes

kokosing reviewed Dec 7, 2021

View reviewed changes

kokosing reviewed Dec 8, 2021

View reviewed changes

kokosing reviewed Dec 9, 2021

View reviewed changes

kokosing reviewed Dec 10, 2021

View reviewed changes

rodolfototaro closed this Dec 10, 2021

rodolfototaro force-pushed the 7461-pr branch from 3a52cdd to 6ebaddb Compare December 10, 2021 14:22

rodolfototaro reopened this Dec 10, 2021

rodolfototaro force-pushed the 7461-pr branch from 5a9ae45 to d7d2bb7 Compare December 10, 2021 20:20

kokosing approved these changes Dec 13, 2021

View reviewed changes

rodolfototaro force-pushed the 7461-pr branch 4 times, most recently from 0f49c8c to 358a3af Compare December 14, 2021 14:36

kokosing reviewed Dec 14, 2021

View reviewed changes

rodolfototaro force-pushed the 7461-pr branch from 358a3af to 9c13ff7 Compare December 14, 2021 15:00

mosabua reviewed Dec 15, 2021

View reviewed changes

docs/src/main/sphinx/security/overview.rst Outdated Show resolved Hide resolved

mosabua reviewed Dec 15, 2021

View reviewed changes

core/trino-main/src/main/java/io/trino/FeaturesConfig.java Outdated Show resolved Hide resolved

rodolfototaro force-pushed the 7461-pr branch 2 times, most recently from ca95ebf to 50e0858 Compare December 15, 2021 09:05

kokosing reviewed Dec 15, 2021

View reviewed changes

docs/src/main/sphinx/security/overview.rst Outdated Show resolved Hide resolved

docs/src/main/sphinx/security/overview.rst Outdated Show resolved Hide resolved

rodolfototaro force-pushed the 7461-pr branch 2 times, most recently from a32b85c to e5ccd69 Compare December 15, 2021 18:43

Allow to hide inaccessible columns

7a1509d

With hide-inaccessible-columns configuration toggle now it is possible to exclude non accessible from SELECT * statement

rodolfototaro force-pushed the 7461-pr branch from e5ccd69 to 7a1509d Compare December 16, 2021 06:44

kokosing merged commit e8bcfe2 into trinodb:master Dec 16, 2021

kokosing mentioned this pull request Dec 16, 2021

Release notes for 367 #10301

Closed

8 tasks

github-actions bot added this to the 367 milestone Dec 16, 2021

caldeirav mentioned this pull request Jan 10, 2022

Upgrade Trino to release 371 os-climate/os_c_data_commons#116

Closed

maltesander mentioned this pull request Apr 12, 2022

Provide and test trino-server-377 stackabletech/trino-operator#187

Closed

7 tasks

		@@ -124,6 +124,18 @@ In addition, Trino :doc:`provides an API </develop/system-access-control>` that
		allows you to create a custom access control method, or to extend an existing

Use AccessControl functionality to filter columns from SELECT *… #9991

Use AccessControl functionality to filter columns from SELECT *… #9991

Conversation

rodolfototaro commented Nov 18, 2021 • edited by findepi Loading

cla-bot bot commented Nov 18, 2021

findepi commented Nov 25, 2021

rodolfototaro commented Nov 25, 2021 • edited Loading

findepi commented Nov 25, 2021

rodolfototaro commented Nov 25, 2021 • edited Loading

findepi commented Nov 26, 2021

rodolfototaro commented Nov 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rodolfototaro commented Dec 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kokosing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rodolfototaro commented Dec 7, 2021

kokosing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kokosing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kokosing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mosabua left a comment

Choose a reason for hiding this comment

kokosing commented Dec 16, 2021

rodolfototaro commented Nov 18, 2021 •

edited by findepi

Loading

rodolfototaro commented Nov 25, 2021 •

edited

Loading

rodolfototaro commented Nov 25, 2021 •

edited

Loading