Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pre-filtering on data types #21

Closed
guignonv opened this issue Feb 4, 2019 · 1 comment
Closed

Implement pre-filtering on data types #21

guignonv opened this issue Feb 4, 2019 · 1 comment

Comments

@guignonv
Copy link
Member

guignonv commented Feb 4, 2019

Some data types may need to be pre-filtered. For instance germplasm and sample share the same table but differ by type_id. The type_id is filtered on the search call but not when an identifier is provided. Therefore, the sample/{sampleDbId} will work with a germplasmDbId while it should not because no-prefiltering occurs.
Another case is the traits/ call that will list all the CV terms, even non-trait ones.
Pre-filtering should be specified in the brapi_get_data_mapping() call.

guignonv pushed a commit that referenced this issue Feb 6, 2019
@guignonv
Copy link
Member Author

guignonv commented Feb 6, 2019

Fixed by commit 027bf89.

@guignonv guignonv closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant