Use center for way pois #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traines-source
commented
May 23, 2025
| return osm::Location{l.location().x() / n, | ||
| l.location().y() / n}; | ||
| }) | ||
| : w.nodes()[w.nodes().size() / 2].location(); |
There was a problem hiding this comment.
Maybe also switch to w.nodes()[w.nodes().size() / 2].location() in lines 88 and 67, to use the approx. middle of a street etc and not one of the ends as the target location?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at using the center of way pois instead of a random node, to avoid something like that:
when using https://www.openstreetmap.org/way/178167136 as the destination.
But then, other issues occur:
Also before:
After:
So probably we need to find another solution...