Switch to global scope repo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
pushed a commit
to forkeith/syntect
that referenced
this pull request
Dec 9, 2017
Clean up and fix with_prototype captures logic
varungandhi-src
pushed a commit
to varungandhi-src/syntect
that referenced
this pull request
Dec 27, 2021
make assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a lazy static global scope repo. This makes everything way nicer.
Performance isn’t an issue since creating scopes isn’t on the critical path.
As an added perf benefit the scope repo is available for you to lock it once and create a bunch of scopes, like the yaml parser currently does.