Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build errors #271

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fixed build errors #271

merged 1 commit into from
Jun 25, 2019

Conversation

RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented May 8, 2019

Hello.
In this pull request I fixed build errors caused by the latest Alamofire v.5.0.0-beta.6. As for me we should use a pattern like s.dependency 'Alamofire', '5.0.0-beta.6' for beta versions of dependencies.
That's why all responseObject functions should accept queue: DispatchQueue = .main - the same way as it is implemented here.
Fixes #267, #270.

@tirrorex
Copy link

tirrorex commented May 28, 2019

Related to #276
Accepting this pull request should allow the library to be updated in swift 5.
Do you see other fixes to do @tristanhimmelman ?
I could take the time and do a quick PR if needed.

@RomanPodymov
Copy link
Contributor Author

RomanPodymov commented Jun 13, 2019

Hello @tristanhimmelman
Could you please release a new beta version of AlamofireObjectMapper with this pull request included? It will be helpful for those who want to use the latest beta Alamofire (currently it is 5.0.0-beta.6).
You can also change the destination branch.

@tristanhimmelman tristanhimmelman merged commit 1793234 into tristanhimmelman:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies to use latest beta of Alamofire beta-5
3 participants