Skip to content

Conversation

Tyler-Lentz
Copy link
Contributor

Sets up some shared infrastructure for all of the unit tests that want to mock GCS handler requests so they can use the same macro instead of redefining it across a ton of different files.

Fixes the macro which has been breaking ever since I updated how the OBC configuration setup works.

Right now this only fixes it for the gcs_server_test unit test. Other tests should be able to run if they remove their own declaration of the macro and include the one in the common header file.

Someone else should try and apply this fix to all of the other tests that use the macro. Feel free to add onto this PR or make another one.

I can explain what is going on easier in a voice call if interested.

@Tyler-Lentz Tyler-Lentz requested review from AskewParity and miyatakazuya and removed request for AskewParity October 17, 2024 02:53
Copy link
Contributor

@AskewParity AskewParity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix

@AskewParity AskewParity merged commit aded5d0 into main Oct 17, 2024
1 of 2 checks passed
@AskewParity AskewParity deleted the fix/unit_tests_handler_macro branch October 17, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants