Skip to content

Unit tests for distanceInMetersBetweenCords function. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Unit tests for distanceInMetersBetweenCords function. #248

merged 2 commits into from
May 27, 2025

Conversation

SofinaYang
Copy link
Contributor

@SofinaYang SofinaYang commented Apr 9, 2025 •
edited
Loading

Fixes #233

  • Unit tests for distanceInMetersBetweenCords function in localization:
  • Set the threshold between the expected and estimated result to be 0.03
  • Used data from https://www.omnicalculator.com/other/latitude-longitude-distance as reference
  • Test cases include distance around thousands kilometers, around a hundred meters, and within 10 meters.

@SofinaYang
Unit tests for distanceInMetersBetweenCords function: set the thresho…
3a18eee 
…ld for the expected and estimated result to be 0.03
@SofinaYang SofinaYang linked an issue Apr 9, 2025 that may be closed by this pull request
Test Localization Distance Calc #233
Closed
miyatakazuya
miyatakazuya approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@miyatakazuya miyatakazuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this works as intended. Nice job!

@miyatakazuya miyatakazuya merged commit 47d9724 into main May 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miyatakazuya miyatakazuya miyatakazuya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Localization Distance Calc
2 participants
@SofinaYang @miyatakazuya