Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove node 7 support #55

Closed
efegurkan opened this issue Aug 27, 2018 · 1 comment
Closed

chore: remove node 7 support #55

efegurkan opened this issue Aug 27, 2018 · 1 comment
Labels
chore

Comments

@efegurkan
Copy link
Contributor

Explain the problem

Since node 7.x is EOL more and more packages dropping support for it. It will be a problem for us as well soon. We should drop support for it soon.

Provide a repository that reproduces issue if possible

#54 has an example for the problem

You can check 7.x EOL

Provide your Environment details

  • Node version: 7

  • Operating System: any

  • melody version: any
ayusharma added a commit to ayusharma/melody that referenced this issue Aug 28, 2018
@ayusharma
chore: drops node-7 and adds node-10 support (trivago#55)
dd44594
ayusharma added a commit to ayusharma/melody that referenced this issue Aug 28, 2018
@ayusharma
chore: drops node-7 and adds node-10 support (trivago#55)
e40768a
@ayusharma
Copy link
Collaborator

We can add node-10 support.

@ayusharma ayusharma mentioned this issue Aug 28, 2018
Merged
pago pushed a commit that referenced this issue Aug 30, 2018
@ayusharma @pago
chore: drops node-7 and adds node-10 support (#55) (#56)
8de8d2b
@pago pago closed this as completed Aug 30, 2018
@efegurkan efegurkan mentioned this issue Aug 30, 2018
Merged
pago pushed a commit that referenced this issue Aug 30, 2018
Merge branch 'master' of https://github.com/trivago/melody into chore…
47bd4d3 
…/ci-release

* 'master' of https://github.com/trivago/melody:
  chore: drops node-7 and adds node-10 support (#55) (#56)
  fix: incorrect `is` method call in melody-types (#20) (#52)
  chore: adds .npmignore for melody packages (#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pago @efegurkan @ayusharma