chore: release scripts for travis #54

efegurkan · 2018-08-23T13:38:34Z

Reference issue: N/A

This PR adds changes to the release scripts and travis config to enable testing melody easier and more flexible at trivago.

With this changes, every push to the master should release a new version to the @next tag with next minor version + commit id. Also for the any branch push it should create a release to the @canary tag.

This also includes a tiny peer dependency updating utility and some prompts before releasing. That should prevent unnecessary patch releases in future.

ayusharma · 2018-08-23T13:41:01Z

bin/ci-release.sh

+  # CANARY RELEASE WITH COMMIT NAME
+  # @commit
+  yarn install && \
+    yarn lerna publish --skip-git --skip-npm --exact --force-publish=*  --canary=commit --registry http://localhost:4873/


localhost:4873 ?

I think it's verdaccio's URL .

true, I forgot to change that one

Add CLI tools/helpers for releasing. Add peer dependency update util. Add npm release for @next and @canary releases.

efegurkan · 2018-08-27T16:26:57Z

This is ready for the review.

@ayusharma please feel free to jump in and comment.

coveralls · 2018-08-27T16:27:49Z

Pull Request Test Coverage Report for Build 141

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.346%

Totals
Change from base Build 112:	0.0%
Covered Lines:	2095
Relevant Lines:	2224

💛 - Coveralls

efegurkan

note to self: Don't forget to add CHANGELOG

ayusharma · 2018-08-27T22:28:23Z

bin/ci-release.sh

+if [ "$TRAVIS_BRANCH" = "master" ]; then
+  # RELEASE AS @NEXT
+  yarn install && \
+    yarn lerna publish --skip-git --exact --force-publish=* --canary=commit --npm-tag=next --registry https://registry.npmjs.org


I am not sure about --exact. There is nothing mentioned in docs https://lernajs.io/#command-publish

Melody uses 2.x version of Lerna still. https://github.com/lerna/lerna/tree/2.x#--exact

ayusharma · 2018-08-27T22:32:45Z

bin/updatePeerDependencies.js

+    }
+
+    Object.keys(pkgJson.peerDependencies).forEach(dep => {
+        if (pkgNames.indexOf(dep) > -1) {


Better to use .includes. 😄

ayusharma

I tested it locally. Added scripts work fine. Looks good to me :)

pago · 2018-08-30T05:16:58Z

@efegurkan Can we get the automated tests to pass?

efegurkan · 2018-08-30T12:38:23Z

@pago It has to be just rebased onto master(#55, #56). I have it locally now, I don't have push rights to a branch anymore.

…/ci-release * 'master' of https://github.com/trivago/melody: chore: drops node-7 and adds node-10 support (#55) (#56) fix: incorrect `is` method call in melody-types (#20) (#52) chore: adds .npmignore for melody packages (#53)

pago · 2018-08-31T04:27:16Z

$ bundlesize
 ERROR  Could not add github status.
        404: Not Found 
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn bundlesize" failed 3 times.
The command "travis_retry yarn bundlesize" exited with 1.

ayusharma · 2018-08-31T08:48:34Z

@pago It's a bug. May be bundlesize version bump can help here. siddharthkp/bundlesize#93 (comment)

efegurkan · 2018-09-06T08:08:54Z

@pago can be also bundlesize token bound to my account? Does it fail on other PR's as well. In that case you need to renew the token.

frvge · 2018-09-08T21:19:23Z

@efegurkan , @pago , I added PR #63 that updates bundlesize in this branch but I'm not sure if that's all what's needed to get rid of the 404 error. I don't have access to the travis environment AFAIK.

efegurkan · 2018-09-11T08:19:30Z

@frvge ask someone to add you to the github organization. You should be able to add the tokens. I cannot work on this PR anymore you know 🤷‍♂️ :D

#65) * chore: Update bundlesize, add secret token, remove npm and lerna warnings * chore: Force non-interactive 'yes' for lerna publish

pago · 2018-09-14T06:34:24Z

Almost there.
@jamesb3ll please add trivagonpm and me as a maintainer for neutrino-preset-melody

I'm not sure why but the npm website currently doesn't list trivagonpm as a maintainer of anything anymore. And @efegurkan seems to have been lost as well.

Once that is done, travis should pass, leaving us with the broken circleci tests on node 6.

ayusharma reviewed Aug 23, 2018

View reviewed changes

chore: release scripts for travis

e574442

Add CLI tools/helpers for releasing. Add peer dependency update util. Add npm release for @next and @canary releases.

efegurkan force-pushed the chore/ci-release branch from 836ef82 to e574442 Compare August 27, 2018 16:23

efegurkan changed the title ~~[WIP]chore: release scripts for travis~~ chore: release scripts for travis Aug 27, 2018

efegurkan requested review from jamesb3ll, pago and krakenfuss August 27, 2018 16:27

efegurkan mentioned this pull request Aug 27, 2018

chore: remove node 7 support #55

Closed

efegurkan commented Aug 27, 2018

View reviewed changes

ayusharma reviewed Aug 27, 2018

View reviewed changes

pago approved these changes Aug 30, 2018

View reviewed changes

chore: Update bundlesize, add secret token, remove npm and lerna warn… (

3398832

#65) * chore: Update bundlesize, add secret token, remove npm and lerna warnings * chore: Force non-interactive 'yes' for lerna publish

chore: sync yarn vs npm usage between circleci and travis

e09ceb6

frvge merged commit 549dcb6 into master Sep 18, 2018

frvge deleted the chore/ci-release branch September 18, 2018 10:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: release scripts for travis #54

chore: release scripts for travis #54

efegurkan commented Aug 23, 2018 •

edited

Loading

ayusharma Aug 23, 2018

ayusharma Aug 23, 2018

efegurkan Aug 23, 2018

efegurkan commented Aug 27, 2018

coveralls commented Aug 27, 2018 •

edited

Loading

efegurkan left a comment •

edited

Loading

ayusharma Aug 27, 2018

efegurkan Aug 30, 2018

ayusharma Aug 27, 2018

ayusharma left a comment

pago commented Aug 30, 2018

efegurkan commented Aug 30, 2018 •

edited

Loading

pago commented Aug 31, 2018

ayusharma commented Aug 31, 2018

efegurkan commented Sep 6, 2018

frvge commented Sep 8, 2018

efegurkan commented Sep 11, 2018

pago commented Sep 14, 2018

chore: release scripts for travis #54

chore: release scripts for travis #54

Conversation

efegurkan commented Aug 23, 2018 • edited Loading

Reference issue: N/A

ayusharma Aug 23, 2018

Choose a reason for hiding this comment

ayusharma Aug 23, 2018

Choose a reason for hiding this comment

efegurkan Aug 23, 2018

Choose a reason for hiding this comment

efegurkan commented Aug 27, 2018

coveralls commented Aug 27, 2018 • edited Loading

Pull Request Test Coverage Report for Build 141

💛 - Coveralls

efegurkan left a comment • edited Loading

Choose a reason for hiding this comment

ayusharma Aug 27, 2018

Choose a reason for hiding this comment

efegurkan Aug 30, 2018

Choose a reason for hiding this comment

ayusharma Aug 27, 2018

Choose a reason for hiding this comment

ayusharma left a comment

Choose a reason for hiding this comment

pago commented Aug 30, 2018

efegurkan commented Aug 30, 2018 • edited Loading

pago commented Aug 31, 2018

ayusharma commented Aug 31, 2018

efegurkan commented Sep 6, 2018

frvge commented Sep 8, 2018

efegurkan commented Sep 11, 2018

pago commented Sep 14, 2018

efegurkan commented Aug 23, 2018 •

edited

Loading

coveralls commented Aug 27, 2018 •

edited

Loading

efegurkan left a comment •

edited

Loading

efegurkan commented Aug 30, 2018 •

edited

Loading