Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Upgrade to babel@7.x.x #122

Closed
wants to merge 15 commits into from

Conversation

ayusharma
Copy link
Collaborator

@ayusharma ayusharma commented May 27, 2019

Reference issue: #122

What changed in this PR:

  • Upgrades following notable dependencies:
    • babel
    • jest
    • typescript
  • Replace Uglify-js with Terser
    Uglify-es is no longer maintained and uglify-js does not support ES6+.

@ayusharma ayusharma requested review from krakenfuss and pago May 27, 2019 08:57
@ayusharma ayusharma changed the title Upgrade to babel@7.x.x [WIP]Upgrade to babel@7.x.x Jun 3, 2019
},
{
"path": "./packages/melody-idom/lib/index.js",
"maxSize": "4.67 kB"
"maxSize": "5.6 kB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea on why this happens and how to prevent it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking into it. 🔍 I changed the uglify with terser. It could be one reason.

@ayusharma ayusharma mentioned this pull request Jun 6, 2019
7 tasks
@ayusharma ayusharma closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants