-
Notifications
You must be signed in to change notification settings - Fork 1.6k
calc storage create new storage; fix bug for storage in vote; fix bug for runtime-bytecode #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix null bug and add test
Add stack out by contract and Triple Trigger test case
do not print tracestack
Donot print stack trace
Judge insufficient balance
Add value equal balance, the deploy will be failed
update config-test-net.conf
…de; 3. don't run vm when timeout in received block
Add save code energy
invalid bytecode return DataWord(0);
feeLimit <= 0, fali
…oliditynode do not print tracestack in SolidityNode.java
fix deepcopy method
opt solidty
Move finalization to test
refine contract state
…t_cost_increase stest_adapt_deploy_contract_cost_increase
CodeNinjaEvan
approved these changes
Sep 4, 2018
tjchern
approved these changes
Sep 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1、bytecode会在部署时,被重新编译为runtime-bytecode,使用故意编造的有错误的bytecode,runtime-bytecode=0,这样在运行runtime-bytecode时,第一条OP是stop,就会正常结束VM的执行,以及执行正常的扣费逻辑。
2、通过智能合约执行投票等,会通过deposit对数据库进行修改。这样,当智能合约执行出现异常时,通过deposit对数据库进行修改也会发生回退。从而保证结果在不同节点上执行的一致性。
3、通过智能合约创建新智能合约时,新增的智能合约所占用的存储也会扣掉相应的Energy。
Why are these changes required?
This PR has been tested by:
Follow up
Extra details