-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add filter test case #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter test case #4183
Conversation
Codecov Report
@@ Coverage Diff @@
## release_v4.4.2 #4183 +/- ##
====================================================
- Coverage 53.10% 53.09% -0.01%
- Complexity 7641 7642 +1
====================================================
Files 812 812
Lines 46166 46166
Branches 5054 5054
====================================================
- Hits 24516 24513 -3
- Misses 19723 19727 +4
+ Partials 1927 1926 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DR
What does this PR do?
Add eth_filter test case for solidity
Why are these changes required?
API should be covered 100%
This PR has been tested by:
Follow up
Extra details