Skip to content

Conversation

wangzichichi
Copy link
Contributor

What does this PR do?
Add eth_filter test case for solidity
Why are these changes required?
API should be covered 100%
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #4183 (84ba3b3) into release_v4.4.2 (ec1c80f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release_v4.4.2    #4183      +/-   ##
====================================================
- Coverage             53.10%   53.09%   -0.01%     
- Complexity             7641     7642       +1     
====================================================
  Files                   812      812              
  Lines                 46166    46166              
  Branches               5054     5054              
====================================================
- Hits                  24516    24513       -3     
- Misses                19723    19727       +4     
+ Partials               1927     1926       -1     
Impacted Files Coverage Δ
.../java/org/tron/core/consensus/BlockHandleImpl.java 63.15% <0.00%> (-15.79%) ⬇️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 85.96% <0.00%> (-3.51%) ⬇️
framework/src/main/java/org/tron/core/Wallet.java 16.71% <0.00%> (+0.04%) ⬆️
.../java/org/tron/common/overlay/server/SyncPool.java 39.31% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1c80f...84ba3b3. Read the comment docs.

Copy link
Contributor

@pangpangfeng pangpangfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangzichichi wangzichichi merged commit f586685 into release_v4.4.2 Dec 15, 2021
Copy link

@Scheusal13 Scheusal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants