Skip to content

Conversation

forfreeday
Copy link
Contributor

@forfreeday forfreeday commented Dec 17, 2021

What does this PR do?
1.upgrade logback version to 1.2.9
Why are these changes required?
1.fix possible security issues with the logging framework.
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #4207 (eed07b4) into master (744b0b8) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4207      +/-   ##
============================================
+ Coverage     53.04%   53.09%   +0.05%     
- Complexity     7630     7640      +10     
============================================
  Files           812      812              
  Lines         46170    46170              
  Branches       5056     5056              
============================================
+ Hits          24491    24515      +24     
+ Misses        19748    19728      -20     
+ Partials       1931     1927       -4     
Impacted Files Coverage Δ
...java/org/tron/core/capsule/TransactionCapsule.java 50.85% <0.00%> (+0.24%) ⬆️
.../main/java/org/tron/core/db2/common/TxCacheDB.java 69.13% <0.00%> (+1.23%) ⬆️
...mework/src/main/java/org/tron/core/db/Manager.java 52.82% <0.00%> (+1.23%) ⬆️
...src/main/java/org/tron/core/db/PendingManager.java 54.54% <0.00%> (+18.18%) ⬆️
...g/tron/core/exception/DupTransactionException.java 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744b0b8...eed07b4. Read the comment docs.

@forfreeday forfreeday changed the title modify logback version upgrade logback version Dec 17, 2021
@forfreeday forfreeday merged commit d87a516 into master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants