Skip to content

Conversation

EdmondDantes
Copy link
Contributor

…in garbage collection

@EdmondDantes EdmondDantes added this to the RFC v1.4 milestone Sep 30, 2025
@EdmondDantes EdmondDantes self-assigned this Sep 30, 2025
@EdmondDantes EdmondDantes added the enhancement New feature or request label Sep 30, 2025
@EdmondDantes EdmondDantes linked an issue Sep 30, 2025 that may be closed by this pull request
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes test output expectations for garbage collection destructor tests to correctly handle the order of operations when coroutines suspend during garbage collection cycles.

  • Corrects the expected output order in two GC destructor test files
  • Adjusts when "Test complete" message appears relative to destructor completion

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/gc/012-gc_destructor_multiple_gc_cycles.phpt Updates expected output order for multiple GC cycles with suspended destructors
tests/gc/011-gc_destructor_cycles_with_suspend.phpt Fixes expected output sequence for GC cycles with coroutine suspension

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@EdmondDantes EdmondDantes merged commit da80a88 into main Oct 1, 2025
1 of 2 checks passed
@EdmondDantes EdmondDantes deleted the 56-implement-the-second-gc-version branch October 1, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the second GC version
1 participant