Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minifier turns (0, eval) into eval #7

Closed
BorisMoore opened this issue Jun 18, 2016 · 2 comments
Closed

Minifier turns (0, eval) into eval #7

BorisMoore opened this issue Jun 18, 2016 · 2 comments
Labels
bug

Comments

@BorisMoore
Copy link

See corresponding issue on AjaxMin: https://ajaxmin.codeplex.com/workitem/22084

See also madskristensen/BundlerMinifier#63 (comment) and BorisMoore/jsviews#323
@BorisMoore BorisMoore mentioned this issue Jun 18, 2016
Closed
@xoofx xoofx added the bug label Jun 21, 2016
xoofx added a commit that referenced this issue Jul 1, 2016
@xoofx
Fix issue with expression (0, eval)('this') that should not be minifi…
cc74cf1 
…ed (#7)
@xoofx
Copy link
Collaborator

xoofx commented Jul 1, 2016

This should be fixed by commit cc74cf1

@xoofx xoofx closed this as completed Jul 1, 2016
@BorisMoore
Copy link
Author

Great, thanks. I have changed JsRender so it no longer depends on this, but other users would potentially have been hit by the same problem - so good to know it is fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BorisMoore @xoofx