Fork Sync: Update from parent repository #60
+1,632,167
−581,342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* add allowed iframe host setting wip * use allowed-iframe-hosts setting in the CSP header * add a test for the frame-src csp directive * Update allowed-iframe-hosts setting definition * Add error state for forbidden iframe url domains * Move out iframe e2e test suite * Add e2e test * Update error message in view mode * Fix unit tests * Update setting on the admin page * Update error state * Add links to error states * Update docs links * Update link anchors * Add default allowed hosts to public setting * Update allowed domain check logic * Fix default value display in admin page * Don't update setting without changes * Update error message spacing * correct the parsing of allowed-hosts string for CSP header entries * fix test * fix not handling wildcard ports * Fix failing e2e test * Fix subdomain test * address review - the parse-allowed-iframe-hosts fn is now memoized - a * entry is handled and doesn't produce a weird *:* entry - no more try/catch, errors in parsing will be logged but the list returns all valid entries - when www. is encountered, an entry including www. is added - trailing / is 'cleaned' and the entry is used as if there was no trailing / * Fixup test for expecting a few more frame sources * indentation fix for linter 🥲 * Fix type error --------- Co-authored-by: Adam James <adam.vermeer2@gmail.com> Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by: dan sutton <dan@dpsutton.com>
… state (#48961) Co-authored-by: Ryan Laurie <iethree@gmail.com>
* converting UpdateAlertModalContent and CreateAlertModalContent to functional * lint stuff * e2e adjustments: * type and e2e adjustments
* pie charts * Apply suggestions from code review Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Co-authored-by: Metabase bot <metabase-bot@metabase.com>
* Remove outdated comment * Add logic for automating npm dist tags * Fix deprecated GitHub action output command * Update .github/workflows/release-embedding-sdk.yml Co-authored-by: Denis Berezin <denis.berezin@metabase.com> * Add comment and correct 51 dist tag --------- Co-authored-by: Denis Berezin <denis.berezin@metabase.com>
* Fix boolean parameter parsing from query string in dashboards * Adjust E2E test * Adjust E2E test * Adjust E2E test * Update e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Update e2e/test/scenarios/filters-reproductions/dashboard-filters-reproductions.cy.spec.js Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
* Fix date formatting of parameter values with time * Update frontend/src/metabase/parameters/utils/date-formatting.ts Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Adjust E2E test * Fix tests --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
* Update X-ray to use rtk query * PR feedback
* implement saving questions in interactive question * close modal on create question * add e2e test for saving questions
…bricks (#49053) * Format databricks as spark in prettify-native-form * Add test to be generalized in follow up
* upgrades is-airgapped? defn to defsetting airgap-enabled - uses the airgap-enabled settings value to remove Cloud section in SettingsEditor - "Metabase Enterprise Airgap" -> "Enterprise Airgap" * hide still need help section in airgap mode * move flag checking into selectors * fe lint * ts type check * use optional chaining and nullish coalescing * hide StillNeedHelp in ag mode * adding airgap-enabled to createMockSettings --------- Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>
…#48808) * cancel request on unmount in static question * use deferred promise * remove logs * alias cancelled to deferred.promise * extract useLoadStaticQuestion hook * add tests for request cancellation * change updateQuestion method * add sanity check with fetchMock
* Fix flaky tests * Fix flaky tests
* Fix flaky test * Bring back waiting * Decrease flakiness
* Map Oracle DATE to type/DateTime * Modify test * Add test
This also cleans up the testing to check everything more carefully, and to expect the right things across multiple stages. (This is a bit tricky since the order-bys get removed when the stage gets aggregated, because the columns they were using are now gone.)
Co-authored-by: Metabase bot <metabase-bot@metabase.com>
* Fixes #33037 * Align query and fix the linter
* Fix flaky test * Add a comment
… settings (#49578) * Use ParameterValueWidget for default value picker in native parameter settings * Fix e2e test * Fix native filter tests * Fix e2e test * Fix e2e test * Add repro for #44665 * Assert that filter values are shown in the popover. Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
* Allow using the arrow buttons to change the limit value * Add a min prop to the number input * Use base-10 Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Ensure number is integer * Add issue name to unit test Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
* update subscription checkboxes * update spec
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
* Try snowflake 3.19.0 * Deafault to java 21 for drivers * Trigger CI * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Try snowflake 3.19.0 * Deafault to java 21 for drivers * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Update deps.edn * Switch to Java 21 * Docker image needs to use --add-opens option * Add note about change to Java 21 to driver changelog --------- Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Luis Paolini <paoliniluis@gmail.com>
…9883) * Update workflow on master * [DEBUG] Disable steps for testing * Add alberto as a reviewer * [DEBUG] modify the branch name for testing * Revert "[DEBUG] modify the branch name for testing" This reverts commit 7d5d8bf. * Revert "[DEBUG] Disable steps for testing" This reverts commit a8662c9.
* Fix flaky models metadata test * Improve hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.