Add support for cargo feature flags

[hobofan]

It would be great to have the ability to specify cargo feature flags for the internal invocation of cargo build.

Maybe it would even make more sense to make this even more generic and pass any number of arguments to the cargo invocation, as this would also cover other flags like "--no-default-features" etc., which otherwise have to be manually mirrored.

[thedodd]

Hey @hobofan, thanks for opening this issue. I think this is a solid idea. My initial thought is that adding the following flags should do the trick: --features <FEATURES>..., --all-features, --no-default-features. I want to add -Z as well, however that has a slightly more complex command structure, and it might be best to leave that off for now as extra credit.

Anyway, @hobofan are you interested in hacking on this? I'm happy to help in whatever way.

[thedodd]

Hey @hobofan just wanted to follow-up on this. Once #73 lands, we will have a pretty solid way to handle this. A little background, the idea with #73 is that we will be able to declare more specific details on the Rust project to be compile like so: <link data-trunk rel="rust" href="path/to/Cargo.toml"/>. That will be in place once #73 lands.

To address the feature requests you've mentioned here, we can add a new data-cargo-features="featureX featureY attribute which will cause trunk to pass those values directly along to the underlying Cargo invocation.

It will be super easy to implement this feature and any other like it. I'll keep this issue up-to-date. Once #73 lands (the 0.7.0 release), would you be interested in getting your feet wet and adding this functionality?

[Tanja-4732]

Hey hobofan, thanks for opening this issue. I think this is a solid idea. My initial thought is that adding the following flags should do the trick: --features <FEATURES>..., --all-features, --no-default-features. I want to add -Z as well, however that has a slightly more complex command structure, and it might be best to leave that off for now as extra credit.

Anyway, hobofan are you interested in hacking on this? I'm happy to help in whatever way.

Well @thedodd, after submitting #160, I think I might give this one a go as well.

I've opened a PR, see #183. I expect this to be done in the next 1-4 days.

[Tanja-4732]

I think my PR #183 should close this issue.

[mpfaff]

I need to pass -Zbuild-std to Cargo. Is there any workaround while we're waiting for this issue?

[janhohenheim]

Any updates on this?

[Tanja-4732]

Any updates on this?

@janhohenheim I'm working on merging the changes into my PR.

Thanks for reminding me 👍

See #183 for details.