-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust workers pipeline #167
Conversation
I've thought a bit more about the issues raised in #46:
EDIT: I forgot |
@joshyrobot love it! I will give the code an 👁️ right now, but I still need to review the discussions we've had over in #46. Overall, I'm stoked that you are tackling this. Thanks for taking the time to do so. One thing I would say before I even got to the initial code review: don't worry about code duplication at this point. While you are doing exploratory work like this, it is way better to duplicate, iterate, find the best patterns, and then when we have something we like, we can do some final deduplication/refactoring. Edit: So, the wasm-opt code can definitely be very easily factored out into its own module. Probably not its own "pipeline" at this point, but at a minimum we can just make it a top-level module under |
@siku2 I know that you had quite a lot of interest in doing some stuff related to Workers. Just wanted to ping you in case you had thoughts to share on this. |
@joshyrobot once you believe this is ready for review, mind marking the PR as ready for review, and then ping me? Happy to start a review on it then. |
Yeah, sorry, I've just been mighty distracted lately. I'll try to pick this back up this week. |
Any updates on this? @joshyrobot seemed to be last active in June :/ |
First iteration of Rust workers! A few notes:
wasm-bindgen
target of eitherno-modules
orweb
, depending on how themodule_workers
config is set (browser interest listed here)/worker.js
(so only one at a time for now), and can then be started vianew Worker("/worker.js", { type: "classic"/"module" })
. This might pose issues with different apublic_url
?/workers/{binary}.js
, but I'm unsure how duplicates should be handledrust_app
pipeline, not too sure where to put the common codeTODO
s related to this pipeline yetChecklist