Skip to content

fix: address self-adding of npm workspace to package.json #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

Strum355
Copy link
Member

Description

The --prefix flag is known to not work on windows. The original fix for this was to os.chdir to the path, perform install operation, and then reset cwd. This worked but had a side effect of adding a self-reference to the package.json. By removing the --prefix flag entirely on windows, the problem is addressed for some reason

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

@Strum355 Strum355 requested a review from ruromero April 29, 2025 14:04
@Strum355 Strum355 merged commit 41dcf84 into trustification:main Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants