fix: address self-adding of npm workspace to package.json #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
--prefix
flag is known to not work on windows. The original fix for this was toos.chdir
to the path, perform install operation, and then reset cwd. This worked but had a side effect of adding a self-reference to the package.json. By removing the--prefix
flag entirely on windows, the problem is addressed for some reasonKeeps overwriting package.json with file:// fabric8-analytics/fabric8-analytics-vscode-extension#731
Auto add self dependency to npm fabric8-analytics/fabric8-analytics-vscode-extension#732
[BUG] alters package.json and generates package-lock.json in projects that don't use npm fabric8-analytics/fabric8-analytics-vscode-extension#738
It keeps inserting a strange dependency into package.json fabric8-analytics/fabric8-analytics-vscode-extension#739
Checklist
Additional information