fix: pip show parsing is incorrect #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add developer test commented out stub in IT to be ready for quick checks Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
when one of the packages contains license key with multi line string value, it can contains the delimiter "---" inside the value ( that separates between the packages in pip show otuput) , hence need to refine the parsing - that is , refine the delimiter Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: potential wrong parsing of pip show with multiline string
When one of the packages contains license key with multi line string value, it can contains the delimiter "---" inside the value ( that separates between the packages in pip show otuput) , hence need to refine the parsing - that is , refine the delimiter.
the problem can be recreated with using in requirements.txt package scipy in python environment >= 3.9.
pip3 show scipy
fixes: https://issues.redhat.com/browse/TC-644
Related issue (if any): fixes #issue_number_goes_here
Checklist