Skip to content

Conversation

zvigrinberg
Copy link
Contributor

@zvigrinberg zvigrinberg commented Nov 2, 2023

Description

For python pip requirements.txt stack analysis:
In case there is a Cyclic reference in python pip dependency tree , then without detecting it and "cut" the cycle, resolving the dependency tree will never end and the API will enter into infinite loop.
So in every case there is a cycle in the dependency tree, detect it, and cut it.

Example

for example, consider sphinx and sphinxcontrib-applehelp, each one is a dependency of the other , as can seen from the following pip show command of both of packages:

image

Fix: https://issues.redhat.com/browse/TC-671

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
@zvigrinberg zvigrinberg merged commit fc4b22b into main Nov 2, 2023
@zvigrinberg zvigrinberg deleted the python-prevent-infinite-loop branch November 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant