Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cricket Sound #115

Closed
crogonint opened this issue Mar 28, 2020 · 10 comments · Fixed by #305
Closed

Cricket Sound #115

crogonint opened this issue Mar 28, 2020 · 10 comments · Fixed by #305
Labels
enhancement New feature or request
Milestone

Comments

@crogonint
Copy link

Could we get the plain cricket noise back? I grew up being sung to sleep be crickets, and it was by far my favorite noise. The current one with the cicadas jars me awake every time the cicada chirps.. until I'm too tired to care.

In would suggest adding 'Crickets' to the list. I'm sure that there are plenty of people from the south who prefer the noise with the cicadas. ;)

@crogonint crogonint added the enhancement New feature or request label Mar 28, 2020
@stale stale bot added the stale label May 16, 2020
@chagretes
Copy link

@crogonint something like this https://freesound.org/people/cs272/sounds/77034/?
Or maybe https://freesound.org/people/rucisko/sounds/250355/ ?

I don't know, it still looks a lot like the existing "night" sound.

@stale stale bot removed the stale label May 16, 2020
@crogonint
Copy link
Author

crogonint commented May 17, 2020 via email

@chagretes
Copy link

Wow, you are really dedicated to the sound of crickets!

I can edit the sounds as directed. I'm just wondering if @ashutoshgngwr will want two types of sounds so similar in the app.

If it is not his wish, I can generate an apk, changing the "night" to this new crickets sound and make it available to you ;)

off topic: when I was a child I collected cicada shells (the exuviae). Their singing (at least the type here in my country) is very annoying

@crogonint
Copy link
Author

crogonint commented May 17, 2020 via email

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented May 17, 2020

@crogonint @chagretes I have already said it before. The idea mentioned in #62 is noble. I am willing to implement it but for audio editing for a inexperienced person is a tedious task. Dual samples made sense when you had earlier proposed them. If someone could go ahead and create dual samples for 2-3 looping sounds, we could try and experiment with it. If the results are satisfying, we can migrate all looping sounds in the library to use smaller (size-wise) dual samples. The other benefit I see is that with smaller samples, we could have more sounds in the library. Take a dedicated cricket sound for example.

My advice to anyone that want to take this up.

  1. Create a fork and branch out of feat/google-cast branch. The LocalSoundPlayer class introduced in that branch would require the minimal code changes to make the experiment work.
  2. Pick 2-3 looping samples from the sound library and download them from their original source.
  3. Edit them as @crogonint has directed in this issue and Dual Samples #62
  4. Notify me so that I can make the code changes in the working branch. Or you could go ahead and do them yourself. Our goal here is to experiment with the results.

Most importantly, discuss the changes you are about to do beforehand so that your work doesn't go to waste.

@crogonint
Copy link
Author

crogonint commented May 17, 2020 via email

@chagretes
Copy link

I really wasn't aware of the other issue.
I believe I have time to do as @ashutoshgngwr suggested. If I start working on it, I will communicate here before. That way we stay aligned

@ashutoshgngwr
Copy link
Member

@crogonint https://www.youtube.com/audiolibrary_download?vid=c9c1711e0dfd1421 How about this sample for Crickets?

@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone May 19, 2020
@crogonint
Copy link
Author

crogonint commented May 22, 2020 via email

@ashutoshgngwr
Copy link
Member

Deferring all sound related changes to 0.9.x in favor of considering to work on #62 which would require rework on all sounds.

@ashutoshgngwr ashutoshgngwr modified the milestones: 0.8.x, 0.9.x Jun 15, 2020
@ashutoshgngwr ashutoshgngwr modified the milestones: 0.9.x, 0.10.x Jul 20, 2020
ashutoshgngwr added a commit that referenced this issue Aug 22, 2020
@ashutoshgngwr ashutoshgngwr mentioned this issue Aug 31, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants