Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify unions with overlapping types #288

Closed
Tracked by #279
italobusi opened this issue Jul 22, 2024 · 2 comments · Fixed by #291
Closed
Tracked by #279

Simplify unions with overlapping types #288

italobusi opened this issue Jul 22, 2024 · 2 comments · Fixed by #291

Comments

@italobusi
Copy link
Collaborator

italobusi commented Jul 22, 2024

union of union types (e.g., te-gen-node-id) includes overlapping types (e.g., inet:ip-address vs. inet:ipv6-address-no-zone): consider simplifying.

@italobusi
Copy link
Collaborator Author

I think this comment applies only to typedef te-gen-node-id .

We can consider removing the typedef te-gen-node-id since it cannot be used alone and moving the union within the grouping te-generic-node-id with the description that the union is disambiguated by the leaf type.

To check that the typedef te-gen-node-id is not used in other models.

@italobusi
Copy link
Collaborator Author

italobusi commented Sep 6, 2024

2024-09-06 TE Call

Agreed resolution as above: #288 (comment)

Confirmed that the typedef te-gen-node-id is not used in other models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant