Addressing RFC8776-bis WG LC comments#291
Merged
italobusi merged 12 commits intotsaad-dev:masterfrom Sep 27, 2024
Merged
Conversation
…IANA-maintained model: fix tsaad-dev#281
Collaborator
Author
|
@tsaad-dev : do we need the state container to contain only the signaled-bandwidth leaf? What about the following change: OLD NEW |
tsaad-dev
reviewed
Sep 26, 2024
| leaf specification-type { | ||
| type te-bandwidth-requested-type; | ||
| description | ||
| "The method used for setting the bandwidth, either |
Owner
There was a problem hiding this comment.
NEW:
The bandwidth specification type, either explicit or automatically computed
tsaad-dev
reviewed
Sep 26, 2024
| Diffserv-aware MPLS Traffic Engineering, | ||
| Section 4.3.1"; | ||
| } | ||
| container state { |
Owner
There was a problem hiding this comment.
do we still use "state" container? Also, shouldn't this be config False?
tsaad-dev
reviewed
Sep 26, 2024
| units "bits/second"; | ||
| description | ||
| "Available bandwith value."; | ||
| "Bandwidth value for Packet links."; |
Owner
There was a problem hiding this comment.
s/Packet links/packet TE links/
tsaad-dev
approved these changes
Sep 26, 2024
Owner
tsaad-dev
left a comment
tsaad-dev
left a comment
There was a problem hiding this comment.
please address couple of small nits
Collaborator
Author
|
2024-09-27 TE Call Agreed to remove the state container and make the signaled-bandwidth config false (see also #291 (comment))
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing additional WG LC comments: