Fix/typescript dependency caching #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves tscircuit#1696 by preventing unnecessary re-downloading of TypeScript dependencies. - Add fetchWithPackageCaching function with 7-day TTL cache - Remove complex closure patterns in ATA fetcher configuration - Simplify @tsci package handling to single URL pattern - Use compression for efficient storage - Remove unnecessary hash functions and error handling complexity The implementation now uses a clean function reference instead of confusing closures: fetcher: fetchWithPackageCaching as typeof fetch
The apiUrl variable is still needed for the AI autocomplete feature. Only the ATA fetcher was simplified to use fetchWithPackageCaching.
Auto-formatted code according to project style guidelines.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
- Add proper type validation for cached data before destructuring - Support all @tsci URL patterns: jsdelivr.net, data.jsdelivr.com resolve/npm - Include jsdelivr_resolve parameter for resolve URLs - Prevent runtime errors from corrupted cache data
Auto-format code for consistency with project style guidelines.
- Add missing package name transformation logic that was in original code - Convert dots to slashes in package names for proper URL routing - Fixes package resolution for @tsci packages with dots in names - Maintains backward compatibility with existing package patterns
|
@seveibar can i get a review on this |
imrishabh18
reviewed
Sep 24, 2025
…ication - Restore CACHE_PREFIX variable and use it consistently - Add TTL check for TypeScript lib files (7-day expiration) - Replace complex regex with simple string operations using indexOf/substring - Apply consistent cache data structure with timestamp for all cached items - Maintain backward compatibility while improving code clarity Addresses feedback from @imrishabh18: - No more complex regex patterns - Proper TTL handling for TypeScript library files - Consistent use of CACHE_PREFIX constant
The original code used /\./ to replace only the FIRST dot, not all dots. Using /\./g could break package resolution for packages with multiple dots. Changes /\./g back to /\./ to maintain backward compatibility with existing package naming conventions.
Extract status, statusText, and headers properties instead of passing the entire Response object. The Response constructor expects a ResponseInit object as the second parameter, not a Response instance. This prevents potential runtime errors and ensures proper response object creation with correct metadata.
|
@imrishabh18 can i get a another round of review for this ? |
|
@seveibar can i get a review on this |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
baeoc
reviewed
Sep 28, 2025
seveibar
reviewed
Sep 29, 2025
|
This is pretty good |
seveibar
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Maybe @imrishabh18 can review & merge if it looks good.
@Sahelisaha04 if you want faster reviews, you can join the discord: https://tscircuit.com/join and shout in the #reviewme channel. Sorry it took so long for me to review
|
okay on it |
|
cc @imrishabh18 can you pls review it |
imrishabh18
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696
/claim #1696
Screencast.From.2025-09-24.14-24-00.1.mp4
adding video