Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritize test datasets #288

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Deprioritize test datasets #288

merged 2 commits into from
Jun 14, 2022

Conversation

sunny8751
Copy link
Collaborator

Summary

Deprioritize test datasets in search results. Can continue to tweak the way we classify which datasets are considered test.

Screenshots or Videos (if applicable)

Screen Shot 2022-06-13 at 9 18 07 AM

@sunny8751 sunny8751 requested a review from jps327 June 13, 2022 13:25
@sunny8751 sunny8751 self-assigned this Jun 13, 2022
Copy link
Contributor

@jps327 jps327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Just a few minor comments around documentation and then you can merge

@sunny8751 sunny8751 merged commit eb07a96 into develop Jun 14, 2022
@sunny8751 sunny8751 deleted the features/test_datasets branch June 14, 2022 02:52
jps327 added a commit that referenced this pull request Oct 20, 2022
* Updated docs and ci workflow (#282)

* Closes #274 and closes #275 - updated UPDATE_ON_BOOT process to be easier to run and quit the server process so it feels more like a script

* Add matching categories in search results (#285)

* Trim whitespace from searches (#286)

* Feature/fake auth (#287)

* Added fake auth and updated readmes

* Updated README and necessary env vars

* Improved environment variable defaults

* Updated PR template

* Update bug_report.md

* Deprioritize test datasets (#288)

* new copy for toggle (#293)

* URL encode collection name (#294)

* button-border-update (#302)

* Focus failures (#307)

* changed border color

* added outline to dataset links

* show Add To Collection button if loading collection from URL (#297)

* always show collection button on datasets

* Make entire Collection card clickable (#321)

* Wrap the Collection card in a Link tag

* Added updated roadmap

* about/welcome copy updates (#320)

* Allow data sync to safely append new changes without recreating entire db every time (#322)

* Change dataset_column id type and make it safe to re-run the seed db without re-creating columns all the time

* Updated elasticsearch indexing to use upsert functionality and to also delete necessary datasets

* Add new command to package.json

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sunwoo Yim <sunny8751@gmail.com>
Co-authored-by: Indraneel Purohit <i.m.indraneel@gmail.com>
Co-authored-by: Indraneel Purohit <indraneel.purohit@twosigma.com>
Co-authored-by: Detroit-the-Dev <70827740+Detroit-the-Dev@users.noreply.github.com>
Co-authored-by: Tiana Wofford <detroit@Tianas-MacBook-Pro.local>
Co-authored-by: Tiana Wofford <detroit@tianas-mbp.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants