Handle clang --version output with a vendor prefix #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several distributions build clang with CLANG_VENDOR defined: https://github.com/llvm/llvm-project/blob/444abb39/clang/lib/Basic/Version.cpp#L96 For example: tony@enceladus:~$ grep PRETTY_NAME /etc/os-release PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" tony@enceladus:~$ clang --version | head -n1 Debian clang version 14.0.6 tony@enceladus:~$ grep PRETTY_NAME /etc/os-release PRETTY_NAME="Ubuntu 22.04.3 LTS" tony@enceladus:~$ clang --version | head -n1 Ubuntu clang version 14.0.0-1ubuntu1.1 openbsd69$ uname -a OpenBSD openbsd69.tony.develop-help.com 6.9 GENERIC#464 amd64 openbsd69$ cc --version | head -n1 OpenBSD clang version 10.0.1 enceladus:~$ clang-15 --version | head -n1 Alpine clang version 15.0.7 enceladus:~$ clang --version | head -n1 Alpine clang version 15.0.7 enceladus:~$ grep PRETTY_NAME /etc/os-release PRETTY_NAME="Alpine Linux v3.17" From https://trac.macports.org/wiki/XcodeVersionInfo : Apple clang version 14.0.0 (clang-1400.0.29.202) so adjust the regexp to allow a leading vendor. It's possible for the vendor to contain spaces, but I haven't found any examples of that in the wild. Keep the match tight by checking for the following " version".
zmughal
approved these changes
Sep 14, 2023
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.